Skip to content

[13.4-stable] Bump eve-libs to pick up the DronaRequest stats race fix - #6705

Merged
rene merged 1 commit into
lf-edge:13.4-stablefrom
christoph-zededa:bump_eve_libs_race_13.4-stable
Oct 5, 2026
Merged

rene merged 1 commit into
lf-edge:13.4-stablefrom
christoph-zededa:bump_eve_libs_race_13.4-stable

Conversation

@christoph-zededa

Copy link
Copy Markdown
Contributor

Description

Bump eve-libs from 06fd0b63af43 to eddbd838d583, the tip of its 13.4-stable
branch, to pick up lf-edge/eve-libs#119: the backport of lf-edge/eve-libs#51,
which makes DronaRequest.GetDoneParts take the request's read lock and has
the AWS and Azure transports update the request's size and status under the
lock, followed by the two nettrace test-skip commits of lf-edge/eve-libs#84
and lf-edge/eve-libs#82 (test-only, nothing of them is vendored).

Why now: #6687 brought TestTransportSendersFinishAfterDownload to this
branch. It drives a request through a real transport under the race detector,
whose stats updater writes doneParts while the downloader reads it through
GetDoneParts, and the test job of #6687 reported that data race.
16.0-stable and master have carried the eve-libs fix since August 2025.

Pillar is the only module on this branch that pins eve-libs. Only the four
zedUpload files the backport touches are re-vendored; no transitive
dependency moves.

How to test and validate this PR

Run pillar's unit tests, which run under the race detector:

make -C pkg/pillar test

Without this bump TestTransportSendersFinishAfterDownload in
cmd/downloader logs WARNING: DATA RACE between
zedUpload.(*DronaRequest).GetDoneParts and zedUpload.recordStats, as in
the test job of #6687; with it the race is gone.

Changelog notes

The download library now reads and writes a request's transfer statistics
under a lock, closing a data race between its statistics updater and the
downloader's progress reporting. No other user-facing changes.

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation — none needed for a dependency bump
  • I've tested my PR on amd64 device — library change, covered by pillar's unit tests under the race detector
  • I've tested my PR on arm64 device — not applicable
  • I've written the test verification instructions
  • I've set the proper labels to this PR — left to the maintainers
  • I've checked the boxes above, or I've provided a good reason why I didn't check them

🤖 Generated with Claude Code

Update eve-libs from 06fd0b63af43 to eddbd838d583, the tip of its
13.4-stable branch, which adds the three commits of
lf-edge/eve-libs#119: the backport of lf-edge/eve-libs#51, followed by
the two nettrace test-skip commits of lf-edge/eve-libs#84 and
lf-edge/eve-libs#82.

The race fix makes GetDoneParts take the request's read lock, which the
stats updater already holds for writing when it records the parts, and
has the AWS and Azure transports update the request's size and status
under the lock as well. Pillar runs its unit tests under the race
detector, and TestTransportSendersFinishAfterDownload, which lf-edge#6687
brought to this branch, drives a request through a real transport whose
stats updater keeps writing those fields while the downloader reads them
from the progress messages; the CI run of that PR reported the race.

The two nettrace commits only change its tests, which are not vendored.
Pillar is the only module on this branch that pins eve-libs; it moves to
the new version, and only the four zedUpload files that the backport
touches are re-vendored. No transitive dependency moves.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@github-actions
github-actions Bot requested a review from eriknordmark October 5, 2026 10:13
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.66%. Comparing base (8077a3d) to head (ca723b9).
⚠️ Report is 288 commits behind head on 13.4-stable.

Additional details and impacted files
@@               Coverage Diff               @@
##           13.4-stable    #6705      +/-   ##
===============================================
+ Coverage        24.78%   32.66%   +7.88%     
===============================================
  Files                8        9       +1     
  Lines             1138     1090      -48     
===============================================
+ Hits               282      356      +74     
+ Misses             788      654     -134     
- Partials            68       80      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christoph-zededa
christoph-zededa marked this pull request as ready for review October 5, 2026 11:08
@rene
rene merged commit 3bbacbc into lf-edge:13.4-stable Oct 5, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants