Repository navigation
[13.4-stable] Bump eve-libs to pick up the DronaRequest stats race fix - #6705
Merged
rene merged 1 commit intoOct 5, 2026
Merged
Conversation
Update eve-libs from 06fd0b63af43 to eddbd838d583, the tip of its 13.4-stable branch, which adds the three commits of lf-edge/eve-libs#119: the backport of lf-edge/eve-libs#51, followed by the two nettrace test-skip commits of lf-edge/eve-libs#84 and lf-edge/eve-libs#82. The race fix makes GetDoneParts take the request's read lock, which the stats updater already holds for writing when it records the parts, and has the AWS and Azure transports update the request's size and status under the lock as well. Pillar runs its unit tests under the race detector, and TestTransportSendersFinishAfterDownload, which lf-edge#6687 brought to this branch, drives a request through a real transport whose stats updater keeps writing those fields while the downloader reads them from the progress messages; the CI run of that PR reported the race. The two nettrace commits only change its tests, which are not vendored. Pillar is the only module on this branch that pins eve-libs; it moves to the new version, and only the four zedUpload files that the backport touches are re-vendored. No transitive dependency moves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 13.4-stable #6705 +/- ##
===============================================
+ Coverage 24.78% 32.66% +7.88%
===============================================
Files 8 9 +1
Lines 1138 1090 -48
===============================================
+ Hits 282 356 +74
+ Misses 788 654 -134
- Partials 68 80 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christoph-zededa
marked this pull request as ready for review
October 5, 2026 11:08
rene
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump eve-libs from 06fd0b63af43 to eddbd838d583, the tip of its 13.4-stable
branch, to pick up lf-edge/eve-libs#119: the backport of lf-edge/eve-libs#51,
which makes
DronaRequest.GetDonePartstake the request's read lock and hasthe AWS and Azure transports update the request's size and status under the
lock, followed by the two nettrace test-skip commits of lf-edge/eve-libs#84
and lf-edge/eve-libs#82 (test-only, nothing of them is vendored).
Why now: #6687 brought
TestTransportSendersFinishAfterDownloadto thisbranch. It drives a request through a real transport under the race detector,
whose stats updater writes
donePartswhile the downloader reads it throughGetDoneParts, and the test job of #6687 reported that data race.16.0-stable and master have carried the eve-libs fix since August 2025.
Pillar is the only module on this branch that pins eve-libs. Only the four
zedUpload files the backport touches are re-vendored; no transitive
dependency moves.
How to test and validate this PR
Run pillar's unit tests, which run under the race detector:
make -C pkg/pillar testWithout this bump
TestTransportSendersFinishAfterDownloadincmd/downloaderlogsWARNING: DATA RACEbetweenzedUpload.(*DronaRequest).GetDonePartsandzedUpload.recordStats, as inthe test job of #6687; with it the race is gone.
Changelog notes
The download library now reads and writes a request's transfer statistics
under a lock, closing a data race between its statistics updater and the
downloader's progress reporting. No other user-facing changes.
PR Backports
Checklist
🤖 Generated with Claude Code