Skip to content

Retire the Xen leftovers: kernel parameters, pillar paths, runx-initrd and docs - #6826

Merged
eriknordmark merged 4 commits into
lf-edge:masterfrom
europaul:retire-xen-naming
Oct 30, 2026
Merged

eriknordmark merged 4 commits into
lf-edge:masterfrom
europaul:retire-xen-naming

Conversation

@europaul

@europaul europaul commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Follow-up to #6743, which moved QEMU into its own pkg/qemu service. This
series removes the Xen leftovers that outlived the Xen support itself: the
kernel parameters only Xen consumed, pillar's internal Xen paths and comments,
the last package whose name carries Xen (pkg/xen-tools, which after #6743
only built runx-initrd), and the documentation that still described EVE as
a two-hypervisor system.

Following the review, the dom0_* GRUB variables and kernel parameters
(dom0_mem, dom0_max_vcpus, dom0_console, dom0_extra_args,
dom0_platform_tweaks) keep their names. They are user overrides in
/config/grub.cfg, which a rootfs update does not replace, and Eden, evetest
and support runbooks write them. The docs now say why they stay.

One commit per logical change:

  • grub: drop the kernel parameters only Xen consumed. dom0_vcpus_pin
    pinned dom0 vCPUs under Xen and Linux ignores it. console=hvc0 was the Xen
    paravirtual console, so on every x86 and arm64 KVM boot it added a console
    that does not exist. It stays on riscv64, where hvc0 is the SBI console.
  • pillar: drop the Xen names from internal paths, comments and build
    flags.
    /run/domainmgr/xen/xen<N>.cfg becomes
    /run/domainmgr/domains/dom<N>.cfg (tmpfs, read only by domainmgr); the rest
    is comments, test strings, the domainmgr doc, and the stale HV=xen entries
    in kernel-version.mk and the squashfs block-size rule.
  • pillar: build runx-initrd in pkg/pillar, retire pkg/xen-tools. The
    initrd's init-initrd is one half of a protocol whose other half is
    pkg/pillar/containerd/oci.go (the cmdline, environment, ug and
    mountPoints files shared into the VM at /mnt). The sources move to
    pkg/pillar/initrd/, pillar's Dockerfile builds them as one more stage, and
    the file ships at /boot/runx-initrd inside pillar's rootfs. QEMU runs in a
    domain whose spec binds / to /hostfs, so the default ramdisk becomes
    /hostfs/containers/services/pillar/rootfs/boot/runx-initrd, the same way
    the kernel already comes from /hostfs/boot/kernel. The legacy
    /usr/lib/xen/boot/runx-initrd a controller or checkpoint may still send is
    mapped to it by the table Upgrade QEMU to 11.1.2 and run it from its own pkg/qemu service #6743 added. The EVE-K external-boot-image copies
    the initrd from the pillar image. pkg/xen-tools is deleted. The
    tools/get-deps test fixture, which used eve-xen-tools as its in-tree
    package example and checks the package directory on disk, now uses
    pkg/qemu; that test is not run by CI, so the breakage only showed up in
    review.
  • docs: describe EVE as KVM-only and explain the Xen names that stay.
    HYPERVISORS.md loses the Xen device-model, toolstack and IOMMU material and
    the dangling link to the Xen spoofing patch, and gains a "Xen, historically"
    section: Xen was available up to 17.5.0 and removed in 17.6.0, which names
    keep the dom0 prefix and why, and that a device updating from a Xen-based
    release needs no manual step. The other docs stop calling the host kernel
    "dom0" or naming Xen as a reason for design choices.

No new Docker Hub repository is needed. The published lfedge/eve-xen-tools
images stay, since every stable branch still builds from them.

Not in this PR, noted for follow-ups: the dom0_mem/eve_mem/ctrd_mem
hard-limit regexes in 010-eve-cgroup can match across arguments;
pkg/dom0-ztools keeps its name; init-initrd's setsid agetty for the shim
console on hvc1 has never found agetty (the kernel gives /init no
PATH, and musl's default path has no /sbin), which predates this series.

PR dependencies

None. Builds on #6743, already merged.

How to test and validate this PR

Build and boot the image (make pkgs live && make run-live), then on the
device:

  1. cat /proc/cmdline: contains dom0_mem=... and dom0_max_vcpus=... as
    before, and no dom0_vcpus_pin, hvc0 or xen token (riscv64 keeps
    console=hvc0).
  2. An existing override still works: put
    set_global hv_dom0_mem_settings "dom0_mem=640M,max:800M dom0_max_vcpus=1"
    in /config/grub.cfg, reboot, and check that the command line carries the
    override and the eve cgroup limits follow it.
  3. ls /containers/services/pillar/rootfs/boot/runx-initrd exists;
    /boot/runx-initrd and /containers/services/xen-tools do not.
  4. Deploy a container app (e.g. with Eden TEST_SMOKE/TEST_UAPP) and check
    it reaches RUNNING. The domain's QEMU command line (ps on the device)
    shows -initrd /hostfs/containers/services/pillar/rootfs/boot/runx-initrd.
  5. ls /run/domainmgr/domains/ holds the dom<N>.cfg files of the running
    domains.
  6. EVE-K: make HV=k pkgs builds pkg/external-boot-image, and the image
    carries /runx-initrd.

Done on amd64 in QEMU: steps 1, 3 and 5, plus a hand-started shim VM (host
kernel, the initrd from pillar's rootfs, a 9p share with a busybox rootfs and
the cmdline/environment/ug files pillar writes), which mounted the
share, ran the command through chroot2 and powered off cleanly. The pillar
unit tests cover the legacy ramdisk path mapping (TestSetBootDefaults),
and go test ./... in tools/get-deps passes.

Upgrade from an older release: the evetest TestEVEUpgrade KVM case was
run locally against this build. A device installed from 16.0.0-lts with a
container app running was upgraded to the PR image, rebooted once, came up on
the new version, and the app was RUNNING and reachable afterwards. The only
Xen-era value that can cross an update, an explicit /usr/lib/xen/boot/...
BootLoader or Ramdisk path from the controller or the checkpoint, goes
through the mapping #6743 added, whose runx-initrd entry now points at the
pillar path.

Changelog notes

The Xen-only dom0_vcpus_pin and console=hvc0 are no longer on the kernel
command line of x86 and arm64 devices. No other user-facing change: the
dom0_* GRUB settings in /config/grub.cfg keep their names.

PR Backports

  • 17.0-stable: No, master-only cleanup after the Xen removal.
  • 16.0-stable: No, master-only cleanup after the Xen removal.
  • 14.5-stable: No, master-only cleanup after the Xen removal.
  • 13.4-stable: No, master-only cleanup after the Xen removal.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

@europaul

Copy link
Copy Markdown
Contributor Author

@eriknordmark @rene @rucoder please let me know what you think. Is renaming the GRUB vars that contain dom0 too much?

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.64%. Comparing base (ce3fd33) to head (f2d2c0c).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pillar/cmd/domainmgr/domainmgr.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6826      +/-   ##
==========================================
+ Coverage   28.33%   28.64%   +0.31%     
==========================================
  Files         537      548      +11     
  Lines       98110    99857    +1747     
==========================================
+ Hits        27802    28608     +806     
- Misses      68054    68800     +746     
- Partials     2254     2449     +195     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rucoder

rucoder commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@europaul i would keep dom0_ prefix, it stil makes sense. besides renaming user facing variables may break existent workflows

@eriknordmark eriknordmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dom0_platform_tweaks is also documented and used.

How do you ensure that the dom0 grub settings which are documented and used in /config/grub.cfg will still work?
Does that handle using 'set' in addition to 'set_global'?

The safer thing would be to keep all of the names which are/might be used in /config/grub.cfg.

@eriknordmark

Copy link
Copy Markdown
Contributor

dom0_platform_tweaks is renamed to kernel_hw_tweaks but is not among the old names set_global keeps in step, so a CONFIG grub.cfg that sets it is silently ignored after the update.

The repo's own README documents one, for the FR201 without eMMC (README.md:360), and this PR leaves it unchanged:

set_global dom0_platform_tweaks "eve_install_disk=sdb rootdelay=10"

With the PR, the board default eve_install_disk=mmcblk0 eve_persist_disk=sdb rootdelay=10 stays in force there.

Fielded devices use it too: in the command lines devices report in ZInfoHardware.kernel_cmdline (16.6.0 and later), a modprobe.blacklist=intel_pch_thermal that no board default sets sits in the dom0_platform_tweaks slot on some devices running recent releases, and support guidance uses the variable for watchdog (acpi_no_watchdog), PCI (pci=realloc=off) and boot-delay (rootdelay=) workarounds.

Could you add dom0_platform_tweaks ↔ kernel_hw_tweaks as a fifth pair in set_global and in the post-override check, update README.md:360, and list it in BOOTING.md? For dom0_cmdline, dom0_flavor_tweaks and dom0_rootfs I found no override in this repo, eden, or the reported command lines.

Eden still writes dom0_console and dom0_extra_args (pkg/eden/eden.go, CI --grub-options), so the aliases need to stay until eden moves to the new names.

Smaller: the post-override check resolves a mismatch in favor of the old name, so a new override written with a bare set kernel_extra_args … is silently replaced by the stale dom0_extra_args value. Either reconcile toward whichever name changed, or state in BOOTING.md that overrides must use set_global.

@rene

rene commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Apart from the comments from @eriknordmark and @rucoder (which I agree), I think the documentation is missing at least a paragraph to explain the Xen was supported in the past and it was decommissioned in favor of kvm. If there is any action that should be taken from devices upgrading from older to newer versions, it must have a migration guide. Keep dom0_ prefix still makes sense and will avoid additional requirements while upgrading EVE.....

@rene

rene commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

@claude

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @rene's task in 4m 10s —— View job


Review complete

I focused on correctness of the Xen→kernel/sys rename, since the compatibility-shimming in pkg/grub/rootfs.cfg and 010-eve-cgroup is where behavior can silently diverge for already-fielded devices. The renames in Go code, docs, and the pkg/xen-tools → pkg/pillar/initrd move look mechanically correct, and the external-boot-image / pillar Dockerfile initrd wiring (/boot/runx-initrd in the pillar image → copied into external-boot-image, shipped at /hostfs/containers/services/pillar/rootfs/boot/runx-initrd) is consistent.

Two correctness findings, both posted inline on pkg/grub/rootfs.cfg:

  • dom0_platform_tweaks has no alias (inline) — renamed to kernel_hw_tweaks but absent from set_global and the post-override reconcile, so a /config/grub.cfg override using the old name is silently dropped on upgrade. It's the one old name that is both documented (README.md:360) and used in the field (modprobe.blacklist=, pci=realloc=off, rootdelay= workarounds). This confirms @eriknordmark's concern; a drop-in fix is in the inline comment.
  • Post-override reconcile prefers the old name (inline) — a new-style bare set kernel_console … override is reverted to the stale old-name value, the opposite of the intent. Either require set_global in the docs or reconcile toward whichever side changed.

One cross-cutting note on the pkg/xen-tools deletion: docs/HYPERVISORS.md:109 still links to ../pkg/xen-tools/patches-4.13.0/05-xen-spoofing.patch, which now points into the deleted package — a dangling link worth cleaning up in this series. (Test fixtures in tools/get-deps / tools/dockerfile-from-checker and pkg/monitor/.../tests.rs still contain xen-tools/dom0_* strings, but those are self-contained string fixtures and don't break.)

On the design question raised in the thread (keeping the dom0_ prefix vs. renaming user-facing GRUB variables): that's a maintainer call, not a correctness issue — but note that whichever way it goes, the aliasing/reconcile logic above must cover every old name that can appear in a fielded /config/grub.cfg, since CONFIG is not replaced by a rootfs update.
· branch retire-xen-naming

Comment thread pkg/grub/rootfs.cfg Resolved
Comment thread pkg/grub/rootfs.cfg Resolved
@europaul europaul changed the title Retire the Xen naming: GRUB parameters, pillar paths and runx-initrd Retire the Xen leftovers: kernel parameters, pillar paths, runx-initrd and docs Oct 19, 2026
@github-actions
github-actions Bot requested a review from eriknordmark October 19, 2026 17:51
@europaul

Copy link
Copy Markdown
Contributor Author

Thanks for the review guys, much appreciated! As per your comments I kept the dom0- names and removed Xen from documentation while adding a paragraph that we used to support it.

@europaul

Copy link
Copy Markdown
Contributor Author

/rerun red

@europaul

Copy link
Copy Markdown
Contributor Author

Could somebody kick off Eden please

@rene

rene commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@europaul, you have a conflict to fix

Comment thread pkg/grub/rootfs.cfg
set_global hv_console "console=com1"
set_global hv_platform_tweaks "$hv_platform_tweaks clocksource=pit"
set_global dom0_platform_tweaks "clocksource=tsc"
set_global dom0_console "console=ttyS0 console=hvc0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you need to remove hvc0, what about if EVE boot as a VM? It should be able to get console on the virtual console...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttyS0 should be enough for that. see #6826 (comment)

@rene

rene commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@claude

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @rene's task in 4m 20s —— View job


Review complete

I reviewed the current state of the branch (the set_global aliasing complexity from the earlier review is gone — the dom0_* names are kept, so those earlier findings are moot). The initrd move (pkg/xen-tools → pkg/pillar/initrd, built as a pillar Dockerfile stage, shipped at /boot/runx-initrd and copied into external-boot-image), the RunxInitrd/legacyBootPaths wiring, and the xen→dom/domains renames in domainmgr all look mechanically correct and consistent.

One correctness finding (inline):

  • Deleting pkg/xen-tools breaks tools/get-deps/main_test.go. TestNoneLinuxKitImage isn't in the diff but asserts the filtered package list is ["pkg/alpine", "pkg/xen-tools"], and filterPkg() drops packages whose directory no longer exists (os.Stat). With the directory gone the test Fatalfs. This contradicts the earlier bot's claim that the fixture is self-contained. A drop-in fix (swap the fixture to pkg/qemu) is in the inline comment. Fix this →

Answer to @rene's hvc0 question (inline): removing console=hvc0 from the x86/arm64 paths is safe — those paths keep ttyS0/tty0, which is the console EVE's QEMU (-serial mon:stdio) and cloud images actually expose; hvc0 (virtio/Xen-PV console) is never wired up by EVE's QEMU, so it was a dead entry on KVM. It's correctly kept on riscv64 (SBI console). The only regression case is a guest exposing only a virtio-console and no serial, which EVE neither configures nor documents.

Everything else (docs, kernel-version.mk, images/rootfs.yml.in, parse-pkgs.sh, external-boot-image, the HYPERVISORS.md dangling-link removal) checks out.

  • Review grub/rootfs.cfg (incl. the hvc0 / "EVE as a VM" question)
  • Review pillar Dockerfile + external-boot-image initrd wiring
  • Review domainmgr path/rename changes
  • Review docs and remaining renames
  • Post inline findings
    · branch retire-xen-naming

Comment thread tools/parse-pkgs.sh
NODE_EXPORTER_TAG=$(linuxkit_tag pkg/node-exporter)
VECTOR_TAG=$(linuxkit_tag pkg/vector)
XENTOOLS_TAG=$(linuxkit_tag pkg/xen-tools)
QEMU_TAG=$(linuxkit_tag pkg/qemu)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting pkg/xen-tools breaks tools/get-deps/main_test.go (TestNoneLinuxKitImage), which is not in this PR's diff but depends on the directory existing. The test feeds a synthetic Dockerfile containing FROM lfedge/eve-xen-tools:$XENTOOLS and asserts the filtered result is ["pkg/alpine", "pkg/xen-tools"]. But filterPkg() does os.Stat("pkg/xen-tools") and drops any package whose directory is absent (tools/get-deps/main.go:213). With pkg/xen-tools gone, the result is only ["pkg/alpine"], so the length check t.Fatalfs.

(Note: this contradicts the earlier bot review, which said these fixtures are "self-contained … and don't break" — they are not, because filterPkg stats the real filesystem.)

Fix: update the fixture in tools/get-deps/main_test.go to reference a package that still exists, e.g. swap the eve-xen-tools line for lfedge/eve-qemu:$QEMU and change expected to ["pkg/alpine", "pkg/qemu"].

make -C ./tools/get-deps (run in CI by check-docker-hashes-consistency.yml) only builds and won't catch this, but any go test ./... in that module will.

Comment thread pkg/grub/rootfs.cfg
set_global hv_platform_tweaks "$hv_platform_tweaks clocksource=pit"
set_global dom0_platform_tweaks "clocksource=tsc"
set_global dom0_console "console=ttyS0 console=hvc0"
set_global dom0_console "console=ttyS0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re @rene's question about EVE booting as a VM: removing console=hvc0 here is safe. This set_x86_64_qemu path (and the set_arm64 one) keeps console=ttyS0/console=tty0, which is the console EVE's own guest/VM setup actually provides — make run boots QEMU with -serial mon:stdio (Makefile:312), i.e. ttyS0/com1, and the cloud images (GCP etc.) use ttyS0 as well. hvc0 is a virtio-console / Xen-PV console device that EVE's QEMU invocation never wires up, so on KVM it was a dead console= entry (the kernel silently ignores a console that doesn't exist).

The only way this regresses is a deployment that runs EVE as a guest exposing only a virtio-console (virtio-serial+virtconsole) and no serial port — not a configuration EVE sets up or documents. hvc0 is correctly preserved on riscv64 (rootfs.cfg:374), where it is the SBI console.

@github-actions
github-actions Bot requested a review from rene October 26, 2026 17:01
Comment thread docs/BOOTING.md Outdated
but also applies for KVM, which means the "host" operating system) the following
arguments should be used:
As an example of using serial port and VGA as a console for the host operating
system (`dom0` is its Xen-era name, see [HYPERVISORS.md](HYPERVISORS.md#xen-historically))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think xen-historically covers the fact that we retain the xen'ish names for the grub options. We should have explicit text about that were we specify the grub option names and have this section refer to that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the comment now to the section of BOOTING.md where we explain the GRUB params.
Or did you mean I should move it to pkg/grub/rootfs.cfg?

@eriknordmark

Copy link
Copy Markdown
Contributor

@europaul This PR conflicts with master and needs a rebase. Its last Go Tests and Fuzz Tests runs were cancelled at the 6h job limit while building eve-cross-compilers:2dad5fbf from source, because that tag had no amd64 image on Docker Hub at the time. Rebasing onto current master picks up the published be9bca50, so those jobs pull it instead of rebuilding gcc.

europaul and others added 4 commits October 29, 2026 11:13
dom0_vcpus_pin pinned the dom0 vCPUs under Xen; Linux ignores it.
console=hvc0 was the Xen paravirtual console, so on every x86 and arm64
KVM boot it has only ever added a console that does not exist (the
QEMU and iPXE entries, and the two i.MX8 boards that listed it). It
stays on riscv64, where hvc0 is the SBI console and nothing to do with
Xen.

dom0_mem and dom0_max_vcpus are kept here: despite the name they size
the eve cgroup on every hypervisor.

Signed-off-by: Paul Gaiduk <paulg@zededa.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The last Xen left in the tree is vocabulary: domainmgr wrote every
hypervisor's domain config under /run/domainmgr/xen as xen<N>.cfg,
comments and docs still talked about xl, pciback and dom0, and the
amd64 squashfs block-size rule and kernel-version.mk still listed an
HV=xen flavor that the top-level Makefile no longer accepts.

The config directory becomes /run/domainmgr/domains/dom<N>.cfg. It is
tmpfs, recreated on every boot and read only by domainmgr, so nothing
on a device sees the move. Everything else is comments, test strings
and the domainmgr doc, whose PCI passthrough and domain config sections
described the Xen implementation.

Signed-off-by: Paul Gaiduk <paulg@zededa.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
runx-initrd is the initrd of the VMs that container apps run in. Its
init script is one half of a protocol whose other half is pillar's
containerd/oci.go: pillar serialises the app's OCI process spec into
the cmdline, environment, ug and mountPoints files of the directory it
shares into the VM at /mnt, and the initrd reads them back, mounts the
volumes and execs the app. Nothing checks that the two sides agree;
they work because they are changed together.

Until now the initrd was built in pkg/xen-tools, which after the move
of QEMU to its own package holds nothing else. Keeping it there means
the format of those files can change in pillar while the initrd is
versioned, built and reviewed elsewhere, under a name that says
nothing about what it does.

So the initrd sources move next to the code they talk to, and pillar's
Dockerfile builds them as one more stage, installed in pillar's own
rootfs. QEMU runs in a domain whose spec binds / to /hostfs, so the
default ramdisk path becomes
/hostfs/containers/services/pillar/rootfs/boot/runx-initrd,
the same way the kernel is already taken from /hostfs/boot/kernel. The
EVE-K boot image copies the file from the pillar image instead.

pkg/xen-tools goes away entirely, the last package whose name carries
Xen. The published lfedge/eve-xen-tools images stay: every stable
branch still builds from them.

The get-deps test fixture used lfedge/eve-xen-tools as its example of
an in-tree package, and the test checks the package directory on disk.
It now uses pkg/qemu.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Paul Gaiduk <paulg@zededa.com>
Xen support was removed in 17.6.0, but the documentation still described
EVE as a two-hypervisor system: HYPERVISORS.md compared Xen and KVM
device models, toolstacks and IOMMU handling, and linked a Xen spoofing
patch that no longer exists; BOOTING.md, BUILD.md and several others
called the host kernel "dom0" or named Xen as a reason for design
choices; domainmgr.md kept a debugging tip about xencommons.

The Xen-specific material goes. BOOTING.md, where the GRUB options are
listed, now says which names carry the dom0 prefix and why they stay:
they are user overrides in /config/grub.cfg, which a rootfs update does
not replace, and Eden, evetest and support runbooks write them.
HYPERVISORS.md gains a section that records when Xen was supported and
which other vocabulary stays and refers to BOOTING.md for the GRUB
names; pkg/dom0-ztools and the storage.dom0.* properties are kept for
the same reason. The section
also states that a device updating from a Xen-based release needs no
manual step, which the legacy boot-path mapping in zedmanager and the
unchanged override names guarantee.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Paul Gaiduk <paulg@zededa.com>

@rene rene left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kicking off tests....

@lf-edge lf-edge deleted a comment from github-actions Bot Oct 29, 2026
@lf-edge lf-edge deleted a comment from github-actions Bot Oct 29, 2026
@milan-zededa

Copy link
Copy Markdown
Contributor

Please ignore evetest for now, I'm still fixing the workflows (e.g. #6970)

@eriknordmark eriknordmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
eriknordmark merged commit 3508904 into lf-edge:master Oct 30, 2026
67 of 82 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Evetest selective skip for this PR (plumbing/Xen-cleanup only: dropping Xen-only kernel params, renaming internal domainmgr paths/comments, and relocating the runx-initrd build from pkg/xen-tools into pkg/pillar):

Skipped as unrelated to the changed area:

  • TestBootstrapSuite — device config bootstrap (static IP/proxy/VLAN/LACP), untouched by this PR
  • TestControllerFaultsSuite — controller connectivity fault handling, untouched
  • TestDatastoreSuite — datastore download mechanics, untouched
  • TestDiagSuite — diag output, untouched
  • TestHardwareSuite — USB hardware hotplug, untouched
  • TestLPSSuite — location profile / radio silence, untouched
  • TestPcibackErrorSuite — PCI passthrough error reporting, untouched
  • TestPortScanSuite — port scanning, untouched
  • TestSecuritySuite — AppArmor/VTPM/vault/cert handling, untouched
  • TestStorageSuite — volumes/ZFS, untouched
  • TestTelemetrySuite — device info/metrics/logs/config reporting, untouched
  • TestPVCUploadReport — PVC/storage reporting, untouched
  • TestVaultKeyKeptOnTPMError — vault/TPM key handling, untouched

Skipped as redundant duplicates:

  • TestNodeClusterSuite, TestNodeClusterResilienceSuite, TestKubeRegistrationSuite — these incidentally boot EVE-K nodes via the same external-boot-image artifact touched by the Dockerfile.in base-image-tag change, but TestKonvertSuite (kept) already exercises that exact KVM→K conversion/build path more directly, matching the PR's own test plan.

Kept (directly or closely related): TestAppsSuite, TestApplicationConnectivitySuite, TestDeviceConnectivitySuite (the PR edits comments inside TestApplicationIPv6Connectivity/TestApplicationNTPConfig/TestDeviceIPv6Connectivity), TestUpgradeSuite (exercises the legacy boot-path mapping for runx-initrd explicitly changed here), and TestKonvertSuite.

An engineer can comment /evetest all to force the full suite to run instead, or /evetest <name> <name> ... to run only specific tests/suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants