Repository navigation
[14.5-stable] pillar: keep purges from leaving the old app generation behind - #6880
Merged
rene merged 1 commit intoOct 26, 2026
Conversation
This was referenced Oct 20, 2026
milan-zededa
force-pushed
the
14.5-backport-6257-purge-stale-volumerefs
branch
2 times, most recently
from
October 20, 2026 07:57
808f290 to
48ed424
Compare
A purge must delete the previous generation of an app before it creates the next one. zedmanager waits for ever for a volume-ref removal. On a purge, doInstall parks the old VolumeRefStatus and waits for volumemgr to confirm the delete. If volumemgr has no live status for that reference in this boot (for example after a reboot), the confirmation never comes. The app stays in DownloadAndVerify and never asks for the new volume. zedmanager now looks at volumemgr's live status first, and drops the reference if it is already absent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com> (cherry picked from commit 9c2eecf) Signed-off-by: Milan Lenco <milan@zededa.com> Partial backport: only the zedmanager change (waiting for ever for a volume-ref removal) and its unit tests are taken. The other changes of the original commit do not apply to this branch and are left out.
milan-zededa
force-pushed
the
14.5-backport-6257-purge-stale-volumerefs
branch
from
October 22, 2026 14:16
48ed424 to
f3e4573
Compare
rene
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6257 to
14.5-stable.Partial backport of #6257 (the original PR is mostly about another hypervisor flavor), cherry-picked with
-xfrom9c2eecf8de; the commit message notes what was left out. Only the zedmanager part is backported, together with its unit tests: an oldVolumeRefStatuswaited forever for a volumemgr update that never comes after a reboot, which left the purge stuck. The backported part applies without conflicts.Without this fix
TestVMAppPurgeAfterPowerCyclefails: a purge issued while the device is rebooting leaves the application stuck.PR dependencies
None.
How to test and validate this PR
Covered by the evetest test
TestVMAppPurgeAfterPowerCycle(added to14.5-stableby #6873):Changelog notes
Fixed an application purge that got stuck when the device was rebooted in the middle of it.
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.