Repository navigation
[14.5-stable] Fixes newc initrd filename null termination - #6881
eriknordmark merged 1 commit into
Conversation
a0c5eb3 to
ff0b433
Compare
|
Go Tests fails here because the bpftrace-compiler tests run past their 1h timeout on the self-hosted runners. #6936 raised the timeout to 5h on 14.5-stable. Re-running doesn't help, because the job tests the PR head. Please rebase onto the current 14.5-stable. |
The newc CPIO format requires filenames to be null-terminated. Calculates namesize to include the null terminator, preventing "initramfs name without nulterm" errors with newer kernels. Signed-off-by: Othonas Soultatos <othonas.s@gmail.com> (cherry picked from commit 76a86d0) Signed-off-by: Milan Lenco <milan@zededa.com>
ff0b433 to
75ebe9c
Compare
Done |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.5-stable #6881 +/- ##
===============================================
+ Coverage 24.97% 25.60% +0.62%
===============================================
Files 8 14 +6
Lines 1185 2882 +1697
===============================================
+ Hits 296 738 +442
- Misses 820 1992 +1172
- Partials 69 152 +83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Based on the diff, this PR only patches GRUB's Skipping the following for this PR run (the nightly job re-runs the full suite regardless, so this only trims this PR's own CI): Unrelated to GRUB/initrd/boot behavior:
Redundant with
An engineer can comment |
Description
Backport of #5412 to
14.5-stable.Clean cherry-pick with
-xfrom76a86d0eee, no conflicts. Only the two GRUB patches of the PR are backported (pkg/grub/patches/0015-...for amd64 andpkg/grub/patches-2.06/0014-...for arm64 and riscv64). They make thenewcpathname in the initrd cpio header NUL-terminated, as the format requires.This is needed, otherwise installation over iPXE (netboot) is broken. The installer ISO is loaded by GRUB as
newc:/installer.iso:.... Kernels since 6.1.120 (the14.5-stablegeneric amd64 kernel is 6.1.177) refuse to unpack such an entry:The installer never starts. Kernels without the check are not affected by the fix: it only makes the header conform to the cpio format.
Without this fix the evetest test
TestBootstrapWithNetworkBootfails.PR dependencies
None.
How to test and validate this PR
Covered by the evetest test
TestBootstrapWithNetworkBoot(added to14.5-stableby #6873):Changelog notes
Fixed installation over iPXE: the installer ISO is now loaded with a NUL-terminated name in the initrd, which kernels 6.1.120 and later require.
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.