Repository navigation
evetest: verify app placement from the newest cluster info - #6889
Merged
milan-zededa merged 2 commits intoOct 28, 2026
Merged
Conversation
github-actions
Bot
requested review from
eriknordmark,
europaul,
milan-zededa and
rucoder
October 20, 2026 20:22
Contributor
Author
|
Opened after more runs of the TestDNIDandBackupDNID evetest for backport PR: #6867 |
Merged
3 tasks done
andrewd-zededa
force-pushed
the
evetest-backupdnid-hardening
branch
from
October 21, 2026 20:06
e0ac25a to
ee7610c
Compare
FindDeviceHostingApp returned the host named by the first device whose stored cluster info mentioned the app. That report can be stale: only the stats leader publishes cluster info, and a node that loses the lease stops publishing without retracting its last report. A report can also list the VMI being replaced next to its successor. FindDeviceHostingApp now trusts only the newest stored report across the cluster's devices, then waits for new reports as before. Finished VMIs are not counted. Add EdgeCluster.WaitUntilAppIsHostedOn for checks after an app moves: it waits until the newest report places the app on the given node and on no other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com>
TestDNIDandBackupDNID failed after vm2 failed back to edge-dev3: the cluster ran vm2 on edge-dev3, but the placement check read a stored cluster info report that still placed it on edge-dev1, its backup node. The check after activation on the backup node has the same race. Use WaitUntilAppIsHostedOn for both checks, and point the HTTP readiness check at the device it returns. On the backup node, expect edge-dev1 itself: edge-dev2 is the tie-breaker and edge-dev3 is down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
evetest-backupdnid-hardening
branch
from
October 26, 2026 20:05
ee7610c to
df3169b
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
manual TestDNIDandBackupDNID run against HV=k ZARCH=amd64 passed |
andrewd-zededa
marked this pull request as ready for review
October 26, 2026 22:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6889 +/- ##
==========================================
+ Coverage 28.32% 28.63% +0.30%
==========================================
Files 537 548 +11
Lines 98110 99857 +1747
==========================================
+ Hits 27790 28592 +802
- Misses 68064 68815 +751
- Partials 2256 2450 +194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestDNIDandBackupDNIDcan fail after vm2 fails back to edge-dev3, even though the cluster runs vm2 on edge-dev3:The placement check read a stale cluster info report.
FindDeviceHostingAppreturned the host named by the first device whose storedZInfoKubeClustermentioned the app. There are three ways that report can be wrong:eve-kube-stats-leaderlease stops publishing without retracting its last report, so that report stays stored indefinitely.Changes:
FindDeviceHostingAppnow trusts only the newest stored report across the cluster's devices, then waits for new reports as before. Finished VMIs are not counted. WithexcludeDevNames, a report listing both an excluded node and a new one now returns the new one.EdgeCluster.WaitUntilAppIsHostedOnis added for checks after an app moves: it waits until the newest report places the app on the given node and no other. The display-name lookup, device lookup and report watching are shared helpers.TestDNIDandBackupDNIDusesWaitUntilAppIsHostedOnfor the failback check and for the check after activation on the backup node, and runs its HTTP readiness check against the device that was verified. The backup-node check now expects edge-dev1 itself rather than "not edge-dev3": edge-dev2 is the tie-breaker and edge-dev3 is down.Draft until the cluster suite has been run against it.
How to test and validate this PR
FindDeviceHostingAppis used throughout the cluster tests, so run the whole suite, not just the one test.TestAppNodeNamesunit-tests the new placement parsing:GOWORK=off go test -run TestAppNodeNames .fromevetest/on Linux.Changelog notes
None. Test framework only.
PR Backports
TestDNIDandBackupDNIDis on 17.0-stable and hits the same race.Checklist
🤖 Generated with Claude Code