Skip to content

[13.4-stable] Fixes newc initrd filename null termination - #6906

Merged
eriknordmark merged 1 commit into
lf-edge:13.4-stablefrom
milan-zededa:13.4-backport-5412-grub-newc-nul
Oct 26, 2026
Merged

eriknordmark merged 1 commit into
lf-edge:13.4-stablefrom
milan-zededa:13.4-backport-5412-grub-newc-nul

Conversation

@milan-zededa

Copy link
Copy Markdown
Contributor

Description

Backport of #5412 to 13.4-stable.

Partial backport, clean cherry-pick with -x from 76a86d0eee, no conflicts. Only the two GRUB patches of the PR are backported (pkg/grub/patches/0015-... for amd64 and pkg/grub/patches-2.06/0014-... for arm64 and riscv64). They make the newc pathname in the initrd cpio header NUL-terminated, as the format requires.

This is needed, otherwise installation over iPXE (netboot) is broken. The installer ISO is loaded by GRUB as newc:/installer.iso:.... Kernels since 6.1.120 refuse to unpack such an entry:

initramfs name without nulterm: installer.iso
rootfs image is not initramfs (malformed archive); looks like an initrd

The installer never starts. Kernels without the check are not affected by the fix: it only makes the header conform to the cpio format.

Without this fix TestBootstrapWithNetworkBoot fails.

PR dependencies

None.

How to test and validate this PR

Covered by the evetest test TestBootstrapWithNetworkBoot (added to 13.4-stable by #6899):

EVETEST_EVE_VERSION=<13.4-stable build with this PR> make evetest NAME=TestBootstrapWithNetworkBoot

Changelog notes

Fixed installation over iPXE: the installer ISO is now loaded with a NUL-terminated name in the initrd, which kernels 6.1.120 and later require.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

The newc CPIO format requires filenames to be null-terminated.
Calculates namesize to include the null terminator, preventing
"initramfs name without nulterm" errors with newer kernels.

Signed-off-by: Othonas Soultatos <othonas.s@gmail.com>
(cherry picked from commit 76a86d0)
Signed-off-by: Milan Lenco <milan@zededa.com>
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.66%. Comparing base (8077a3d) to head (8dea4be).
⚠️ Report is 319 commits behind head on 13.4-stable.

Additional details and impacted files
@@               Coverage Diff               @@
##           13.4-stable    #6906      +/-   ##
===============================================
+ Coverage        24.78%   32.66%   +7.88%     
===============================================
  Files                8        9       +1     
  Lines             1138     1090      -48     
===============================================
+ Hits               282      356      +74     
+ Misses             788      654     -134     
- Partials            68       80      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark
eriknordmark merged commit 33a8bb6 into lf-edge:13.4-stable Oct 26, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants