Repository navigation
[13.4-stable] dpcreconciler: pass the IP version mode to dhcpcd --release and --exit - #6907
Merged
eriknordmark merged 1 commit intoOct 26, 2026
Conversation
dhcpcd started with --ipv4only or --ipv6only keeps its PID file and control socket under a mode-specific name. "dhcpcd --release" and "dhcpcd --exit" without the same flag therefore fail with "dhcpcd is not running" while the process is alive, so a DHCP client could never be stopped. For example, switching an IPv4-only DHCP port to a static IP left the old dhcpcd (and its lease) in place and the new config could not be applied. Pass the flag to both commands, as dhcpcdExists already does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
4 of 7 tasks
milan-zededa
requested review from
OhmSpectator,
andrewd-zededa,
christoph-zededa,
naiming-zededa,
rouming,
rucoder,
uncleDecart and
zedi-pramodh
October 22, 2026 08:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 13.4-stable #6907 +/- ##
===============================================
+ Coverage 24.78% 32.66% +7.88%
===============================================
Files 8 9 +1
Lines 1138 1090 -48
===============================================
+ Hits 282 356 +74
+ Misses 788 654 -134
- Partials 68 80 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rene
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of a small part of #5076 to
13.4-stable(that PR was backported to14.5-stableas #5143).Partial backport and a complete rework: this is not a cherry-pick. #5076 upgrades dhcpcd and adds IPv6 support, none of which is in
13.4-stable(it uses the dhcpcd from Alpine). Only one detail of its dhcpcd handling is applied by hand:dhcpcd --releaseanddhcpcd --exitget the same--ipv4only/--ipv6onlyflag the client was started with.dhcpcd started with
--ipv4onlyor--ipv6onlykeeps its PID file and control socket under a mode-specific name, so both commands without the flag fail with "dhcpcd is not running" while the process is alive. A DHCP client could never be stopped; for example, switching an IPv4-only DHCP port to a static IP left the old dhcpcd (and its lease) in place and the new config could not be applied.Without this fix
TestNetworkConfigFallbackfails.PR dependencies
None.
How to test and validate this PR
Covered by the evetest test
TestNetworkConfigFallback(added to13.4-stableby #6899):Changelog notes
Fixed stopping of the DHCP client of a port started in IPv4-only or IPv6-only mode, which prevented switching such a port to a static IP configuration.
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.