Skip to content

eden-trusted: retry status API calls - #6940

Merged
rene merged 1 commit into
lf-edge:masterfrom
eriknordmark:eden-status-retries
Oct 29, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
eriknordmark:eden-status-retries

Conversation

@eriknordmark

Copy link
Copy Markdown
Contributor

Description

The steps in eden-trusted.yml that publish Eden results as commit statuses
call the GitHub API with retries: 0, so a single 5xx fails the job. When
"Render each Eden jobs status" fails, the per-suite statuses from the previous
attempt stay on the PR. A suite that passed on re-run then still shows
failure, and the PR stays red until someone re-runs that job by hand. This
happened on #6875: the jobs listing returned 502 after about 10 s on two
consecutive attempts.

This PR retries each of the three actions/github-script steps up to three
times, with back-off at 1 s, 4 s and 9 s. 5xx is not in the default retry-exempt
list. The render step also fetches the job list in pages of 50, so each request
is lighter and a run with more than 100 jobs is no longer truncated.

How to test and validate this PR

This is a CI-only change with nothing to system-test. It cannot be exercised
from its own PR: PR build ignores .github/**, and Run Eden is a
workflow_run workflow, so GitHub always runs master's copy. After merge, check
on any PR's Run Eden run that "Reset & Render Eden statuses", "Eden Tests
Complete" and "Render each Eden jobs status" pass, and that each Eden suite
appears as its own commit status on the PR head.

Changelog notes

None.

PR Backports

Run Eden is triggered by workflow_run, so PRs against every stable branch run
master's copy of this workflow.

  • 17.0-stable: No, master's workflow is used.
  • 16.0-stable: No, master's workflow is used.
  • 14.5-stable: No, master's workflow is used.
  • 13.4-stable: No, master's workflow is used.

Checklist

  • I've provided a proper description

  • I've added the proper documentation

  • I've tested my PR on amd64 device

  • I've tested my PR on arm64 device

  • I've written the test verification instructions

  • I've set the proper labels to this PR

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them. This is a CI workflow change: no documentation or device testing
    applies.

🤖 Generated with Claude Code

The steps that publish Eden results as commit statuses call the GitHub
API with no retries, so a single 5xx fails the job. When the per-suite
render fails, the previous attempt's statuses stay on the PR, so a
suite that passed on re-run still shows failure. The PR then stays red
until someone re-runs the job by hand. On one run with several attempts,
the jobs listing returned 502 after about 10 s, twice in a row.

Retry each status step up to three times. Fetch the job list in pages
of 50, so each request is lighter and a run with more than 100 jobs is
not silently truncated.

Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rene
rene merged commit bbd1ada into lf-edge:master Oct 29, 2026
40 of 41 checks passed
@eriknordmark
eriknordmark deleted the eden-status-retries branch October 31, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants