Repository navigation
pkg/pillar: update zededa/ghw for the CPU topology facts - #6942
Merged
Merged
Conversation
zededa/ghw's eve/v0.26.0 branch now reports, for each online logical processor, its package, core, NUMA node, core type (performance, efficiency or uniform) and frequencies; every cache instance with the logical processors sharing it; the offline logical processors; and the CPUs local to each PCI device. Pillar's CPU placement and hardware inventory will use them in place of reading sysfs themselves. The CPU inventory pillar reports today is unchanged on every ghw snapshot, x86 and arm64. It changes only on boards whose device tree numbers cores per cluster inside one package: there ghw used to merge the cores of different clusters that share a core_id, and now reports each core. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
christoph-zededa
approved these changes
Oct 27, 2026
3 of 7 tasks
rucoder
force-pushed
the
rucoder/ghw-cpu-topology
branch
from
October 27, 2026 14:33
6c87152 to
8aca879
Compare
christoph-zededa
approved these changes
Oct 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6942 +/- ##
==========================================
+ Coverage 28.48% 28.77% +0.29%
==========================================
Files 540 551 +11
Lines 98258 100005 +1747
==========================================
+ Hits 27985 28780 +795
- Misses 68003 68761 +758
- Partials 2270 2464 +194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Repins pillar's vendored
github.com/zededa/ghwto the tip of itseve/v0.26.0branch (e655b8f), after zededa/ghw#9 merged. That PR adds the CPU topology facts EVE needs for CPU placement and for the hardware inventory:It also fixes the topology of ARM boards whose device tree numbers cores per cluster inside one package, where cores of different clusters that share a
core_idused to be merged into one.Only
go.mod,go.sumand the vendored ghw change; master's hand-patched vendoredcnirpc.gois left as it is. No pillar code changes. The new facts are used by follow-up PRs (the CPU topology library and the CPU part of the hardware inventory).How to test and validate this PR
make pillar-vetand the pillar unit tests ofhardwareandcmd/usbmanagerpass.ghwcfrom zededa/ghweve/v0.26.0before and after Replace zedpac C #9 and runghwc cpu -s <snapshot>with each.core_idper cluster in one package, the inventory now lists every core instead of merging them.Changelog notes
No user-facing changes.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them. (Not tested on devices: the inventory output was compared on snapshots of amd64 and arm64 devices instead.)