Skip to content

pkg/pillar: update zededa/ghw for the CPU topology facts - #6942

Merged
eriknordmark merged 1 commit into
lf-edge:masterfrom
rucoder:rucoder/ghw-cpu-topology
Oct 28, 2026
Merged

eriknordmark merged 1 commit into
lf-edge:masterfrom
rucoder:rucoder/ghw-cpu-topology

Conversation

@rucoder

@rucoder rucoder commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Repins pillar's vendored github.com/zededa/ghw to the tip of its eve/v0.26.0 branch (e655b8f), after zededa/ghw#9 merged. That PR adds the CPU topology facts EVE needs for CPU placement and for the hardware inventory:

  • for each online logical processor: its package, core, NUMA node, core type (performance, efficiency or uniform) and base and maximum frequencies;
  • every cache instance, with the logical processors that share it;
  • the logical processors that are present but offline;
  • the CPUs local to each PCI device.

It also fixes the topology of ARM boards whose device tree numbers cores per cluster inside one package, where cores of different clusters that share a core_id used to be merged into one.

Only go.mod, go.sum and the vendored ghw change; master's hand-patched vendored cnirpc.go is left as it is. No pillar code changes. The new facts are used by follow-up PRs (the CPU topology library and the CPU part of the hardware inventory).

How to test and validate this PR

  • make pillar-vet and the pillar unit tests of hardware and cmd/usbmanager pass.
  • The CPU inventory pillar reports (each core's ID, the model and the vendor) is identical before and after this bump on all 13 ghw snapshots. These are x86 and arm64 machines, including a 13th-gen Intel hybrid and a Jetson AGX Orin. To compare, build ghwc from zededa/ghw eve/v0.26.0 before and after Replace zedpac C #9 and run ghwc cpu -s <snapshot> with each.
  • On a device whose device tree repeats core_id per cluster in one package, the inventory now lists every core instead of merging them.

Changelog notes

No user-facing changes.

PR Backports

  • 17.0-stable: No, dependency update for new features.
  • 16.0-stable: No, dependency update for new features.
  • 14.5-stable: No, dependency update for new features.
  • 13.4-stable: No, dependency update for new features.

Checklist

  • I've provided a proper description

  • I've added the proper documentation

  • I've tested my PR on amd64 device

  • I've tested my PR on arm64 device

  • I've written the test verification instructions

  • I've set the proper labels to this PR

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them. (Not tested on devices: the inventory output was compared on snapshots of amd64 and arm64 devices instead.)

zededa/ghw's eve/v0.26.0 branch now reports, for each online logical
processor, its package, core, NUMA node, core type (performance,
efficiency or uniform) and frequencies; every cache instance with the
logical processors sharing it; the offline logical processors; and the
CPUs local to each PCI device. Pillar's CPU placement and hardware
inventory will use them in place of reading sysfs themselves.

The CPU inventory pillar reports today is unchanged on every ghw
snapshot, x86 and arm64. It changes only on boards whose device tree
numbers cores per cluster inside one package: there ghw used to merge
the cores of different clusters that share a core_id, and now reports
each core.

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder
rucoder requested a review from eriknordmark as a code owner October 27, 2026 12:24
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.77%. Comparing base (8d07232) to head (8aca879).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6942      +/-   ##
==========================================
+ Coverage   28.48%   28.77%   +0.29%     
==========================================
  Files         540      551      +11     
  Lines       98258   100005    +1747     
==========================================
+ Hits        27985    28780     +795     
- Misses      68003    68761     +758     
- Partials     2270     2464     +194     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark
eriknordmark merged commit 090ed5a into lf-edge:master Oct 28, 2026
100 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants