Repository navigation
evetest: push SDN image to a remote broker and fix a skipped-subtest deadlock - #6968
Merged
Merged
Conversation
A remote broker pulls the SDN image itself, so an SDN image built from an unmerged change was unavailable to it and every test failed. When SetupDevices can neither find nor pull the SDN image, the broker still fails the request with the pull error, now as a FailedPrecondition status carrying an ErrorInfo detail with a dedicated reason. A harness that recognizes it uploads its local copy through the new PushSDNContainerImage RPC and repeats the request, as it already does for the EVE container image. An older harness just fails with the pull error. The broker-side receive logic and the harness-side upload loop are shared between the two image types. make evetest now ensures the local SDN image also with a remote broker. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Init takes testM before checking EVETEST_SKIP for a suite subtest, but the skip path called t.Skipf without releasing it. Skipf ends the goroutine via runtime.Goexit, leaving testM held, so the next testM.Lock() in RunTestSuite blocked forever and the run hung. Unlock testM before skipping, like every other exit from this branch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
6 of 7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6968 +/- ##
==========================================
+ Coverage 28.48% 28.77% +0.28%
==========================================
Files 540 551 +11
Lines 98258 100005 +1747
==========================================
+ Hits 27990 28772 +782
- Misses 67998 68769 +771
- Partials 2270 2464 +194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow the nightly trigger to set the collect-coverage workflow input, so a cron can enable coverage collection on selected days only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
rene
approved these changes
Oct 29, 2026
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues found while testing the evetest CI, so it is necessary
to get it in for the evetest CI to work properly. It contains two fixes and a small addition to the nightly trigger script.
Push the SDN image from the evetest harness to a remote broker.
The CI uses a remote broker, which pulls the SDN image itself. When a PR changes
the SDN (e.g. #6929), the new SDN image is not published, so the broker cannot get it and all
tests fail. The same is solved for EVE images by pushing them from the harness to
the broker; this PR does the same for the SDN image:
SetupDevicesstill fails the request when the broker has the SDN image neitherlocally nor can pull it, but the error is now a
FailedPreconditionstatus withan
ErrorInfodetail (reasonMISSING_SDN_CONTAINER_IMAGE). Nothing has beenprovisioned at that point.
PushSDNContainerImageRPC and repeatsSetupDevices. An older harness justfails with the pull error, as before.
between the EVE and SDN images.
make evetestnow ensures the local SDN image also with a remote broker(still skipped when
EVETEST_SDN_VERSIONis set explicitly).Fix a deadlock when a suite subtest is skipped by
EVETEST_SKIP.InittakestestMbefore checkingEVETEST_SKIPfor a suite subtest, but theskip path called
t.Skipfwithout releasing it.Skipfends the goroutine, leavingtestMheld, so the nexttestM.Lock()inRunTestSuiteblocked forever andthe run hung.
testMis now unlocked before skipping, like on every other exitfrom that branch.
Allow enabling coverage in the nightly trigger script.
evetest/deploy/proxmox/trigger-evetest-nightly.shgets a--collect-coverageflag, which sets the
collect-coverageinput of the evetest-nightly workflow(off by default). This lets the cron driving the nightly run enable coverage
collection on selected days only, e.g. on Sundays.
How to test and validate this PR
make evetest NAME=<test>against a remote broker (EVETEST_BROKER_ADDRESS)with an SDN image that was built locally and is not published (e.g. after changing
anything under
evetest/sdn/). The harness logs that the broker is missing the SDNcontainer image, pushes it, and the test proceeds. Before this change, it failed
with a pull error.
EVETEST_SKIPmatching one of its subtests. The subtest isskipped and the remaining subtests run, instead of the run hanging.
PR.
go vetandgo testpass forevetestandevetest/broker, andTestIsMissingSDNImageErrcovers the detection of the broker error.Changelog notes
None. Only the evetest test framework and its CI are changed, with no user-facing
changes.
PR Backports
Checklist
And the last but not least:
I've checked the boxes above, or I've provided a good reason why I didn't
check them.
The change only affects the evetest framework and the broker, not EVE itself,
so there is no EVE device to test it on.
🤖 Generated with Claude Code