Repository navigation
evetest-pr: retry status posting, collapse stale evetest comments - #6975
Conversation
c3860eb to
9ca3217
Compare
|
Claude finished @eriknordmark's task in 2m 36s —— View job Review completeI reviewed the three changes (status retry, single skip comment, collapsing analysis comments). Posted 3 inline comments:
Summary of findings (details inline):
The core retry logic, delete-then-repost approach, and per-suite markers otherwise look correct and match the stated intent. |
9ca3217 to
296b9df
Compare
The "Report suite statuses" step posts one commit status per suite in a quick burst. A single 5xx from the GitHub status API aborted the whole discover-suites job and, with it, the evetest run. Retry with backoff on 5xx, 429 and 403 before giving up. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Claude used to post a new PR comment on every evetest run that skipped tests, so reruns piled up stale comments. Have the workflow post the summary instead: a marker-tagged comment is updated in place for the latest run, and removed when the latest run skips nothing (e.g. after "/evetest all"). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Every failed run posted a new analysis comment, so reruns piled up stale ones. Tag the comment with a per-suite marker and, at the end of each run (unless cancelled), collapse the suite's previous comment: as resolved if the run passed, as outdated if it failed again. A new comment is posted only when the run failed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
296b9df to
8ce8572
Compare
Description
Three fixes to the
evetest-prworkflow:commit status per suite in a quick burst. A single transient 5xx from the
GitHub status API aborted the whole
discover-suitesjob and, with it, theevetest run. Statuses are now posted with retries and backoff on 5xx, 429
and 403.
new PR comment on every evetest run that skipped tests, so reruns piled up
stale comments. Claude now writes the comment body to
.evetest-skip/comment.mdand the workflow posts it. Any previousevetest skip comment is deleted and the new one is posted at the end of the
conversation. If the latest run skips nothing (e.g. after
/evetest all),no comment is left on the PR.
new Claude analysis comment, so reruns piled up stale ones. Each comment is
now tagged with a per-suite marker; at the end of a run the suite's
previous comment is collapsed (as resolved if the run passed, as outdated
if it failed again) and a new one is posted only if the run failed.
PR dependencies
Based on the evetest-pr dedupe change that is already in master (
389299ac7d).How to test and validate this PR
CI workflow change; it can only be exercised on a real PR:
there must be exactly one skip comment, at the end of the conversation,
describing the latest run.
/evetest all: the previous skip comment must be removed.HttpError: Unexpected end of JSON input, status 500, in run 40941552841)must no longer fail
discover-suites; a warning is logged per retry.comment must be collapsed as outdated when it fails again (with a new
comment posted) and collapsed as resolved when the rerun passes.
Changelog notes
None. No user-facing changes (CI only).
PR Backports
This PR will not be backported on its own. Instead, all evetest workflow files
will be submitted to all LTS branches together once they are confirmed to work
well.
Checklist
And the last but not least:
check them.
🤖 Generated with Claude Code