Skip to content

evetest ci: resolve the PR in lf-edge/eve, not the fork - #7003

Merged
rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-ci-gh-repo
Nov 2, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-ci-gh-repo

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

For PRs from forks, evetest-pr checks out the PR's head repository, so the
git remote in the runner workspace points at the fork. Without GH_REPO, gh
infers the repository from that remote, and both of these look up the PR number
in the fork instead of lf-edge/eve:

  • gh pr comment in the "Post Claude's analysis as a PR comment" step, which
    fails with GraphQL: Could not resolve to a PullRequest with the number of N.
    The step has continue-on-error: true, so it fails silently and no analysis
    comment is posted (seen on 2-Node HA, part 1: witness as the third etcd voting member #6933, run 41236995199).
  • gh pr diff in live-investigation-watcher.sh, which logs
    could not fetch the diff for PR #N, so Claude investigates failures without
    the PR diff and can't judge whether the PR caused them.

This PR sets GH_REPO: ${{ github.repository }} for both steps, as the step that
collapses previous analysis comments already does.

How to test and validate this PR

On a PR opened from a fork with a failing evetest suite, run /evetest. Then
check that:

  • the job log of the failing suite shows fetched the diff for PR #N instead
    of could not fetch the diff for PR #N;
  • the "Post Claude's analysis as a PR comment" step succeeds, and the PR gets
    a <suite>: failure analysis comment.

Changelog notes

None (CI tooling only).

PR Backports

Not to be backported standalone. The evetest workflow files will be backported
as a whole once they work correctly.

Checklist

  • I've provided a proper description
  • I've added the proper documentation (not needed for a CI fix)
  • I've tested my PR on amd64 device (CI-only change)
  • I've tested my PR on arm64 device (CI-only change)
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

For PRs from forks, evetest-pr checks out the PR's head repository, so
the git remote in the workspace points at the fork. Without GH_REPO,
gh infers the repository from that remote, and both `gh pr comment`
(posting Claude's failure analysis) and `gh pr diff` (in
live-investigation-watcher.sh) look up the PR number in the fork and
fail with "Could not resolve to a PullRequest". The analysis comment
step has continue-on-error, so it failed silently and no analysis was
posted; the watcher likewise ran Claude without the PR diff.

Set GH_REPO to github.repository for both steps, as the step that
collapses previous analysis comments already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa milan-zededa added the testing New test or test framework changes label Nov 1, 2026
@github-actions
github-actions Bot requested a review from europaul November 1, 2026 18:35
@rene
rene merged commit f4b5c6a into lf-edge:master Nov 2, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants