Repository navigation
evetest-pr: compute the failure-analysis PR diff with git - #7021
Merged
Merged
Conversation
The live-investigation watcher still fetched the PR diff with `gh pr diff`, which the API refuses for PRs touching more than 300 files (e.g. vendor bumps). Claude was then told no diff was supplied. Move the git-based diff computation, introduced for the test-skipping step, into .github/actions/evetest-run-suite/pr-diff.sh and use it from both the workflow and the watcher. Vendored code stays excluded and is summarised in pr-vendored.txt. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
requested review from
eriknordmark,
rene,
shjala and
yash-zededa
as code owners
November 3, 2026 16:15
rene
approved these changes
Nov 4, 2026
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The live-investigation watcher of the
evetest-prworkflow still fetched thePR diff with
gh pr diff, which the GitHub API refuses for PRs touching morethan 300 files (e.g. vendor bumps). Claude's failure analysis was then told
"No PR diff was supplied" and could not judge whether a failure relates to the
PR. This was seen on #5644.
This is a follow-up to #7012, which switched the test-skipping step to a
git-based diff for the same reason. That computation is now moved
into
.github/actions/evetest-run-suite/pr-diff.shand used by both theworkflow and the watcher. Vendored code stays excluded from the diff and the
vendored modules added, removed or bumped are listed in
pr-vendored.txt,which Claude is pointed at.
Note on trust: the watcher runs
pr-diff.shfrom the directory it lives in,so the helper comes from whichever copy of
.github/actions/evetest-run-suite/the job runs. On its own this PR changes nothing in that respect: it is the PR
checkout (possibly a fork), exactly like the watcher itself. Once #7022 is
merged, that directory is replaced with the base branch's copy before the
action runs, so the helper is then the base's too.
How to test and validate this PR
CI workflow change only; not yet run in CI. The helper was run locally against
the diff of #5644 (4749 lines, 113 vendored module changes summarised). After
merge, check that the failure-analysis comments of a PR with a large diff
(e.g. one containing a vendor bump) no longer say "No PR diff was supplied".
Changelog notes
None. No user-facing changes (CI tooling only).
PR Backports
Checklist
And the last but not least:
check them.
🤖 Generated with Claude Code