Skip to content

evetest-pr: compute the failure-analysis PR diff with git - #7021

Merged
rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-pr-diff-git
Nov 4, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-pr-diff-git

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

The live-investigation watcher of the evetest-pr workflow still fetched the
PR diff with gh pr diff, which the GitHub API refuses for PRs touching more
than 300 files (e.g. vendor bumps). Claude's failure analysis was then told
"No PR diff was supplied" and could not judge whether a failure relates to the
PR. This was seen on #5644.

This is a follow-up to #7012, which switched the test-skipping step to a
git-based diff for the same reason. That computation is now moved
into .github/actions/evetest-run-suite/pr-diff.sh and used by both the
workflow and the watcher. Vendored code stays excluded from the diff and the
vendored modules added, removed or bumped are listed in pr-vendored.txt,
which Claude is pointed at.

Note on trust: the watcher runs pr-diff.sh from the directory it lives in,
so the helper comes from whichever copy of .github/actions/evetest-run-suite/
the job runs. On its own this PR changes nothing in that respect: it is the PR
checkout (possibly a fork), exactly like the watcher itself. Once #7022 is
merged, that directory is replaced with the base branch's copy before the
action runs, so the helper is then the base's too.

How to test and validate this PR

CI workflow change only; not yet run in CI. The helper was run locally against
the diff of #5644 (4749 lines, 113 vendored module changes summarised). After
merge, check that the failure-analysis comments of a PR with a large diff
(e.g. one containing a vendor bump) no longer say "No PR diff was supplied".

Changelog notes

None. No user-facing changes (CI tooling only).

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

The live-investigation watcher still fetched the PR diff with
`gh pr diff`, which the API refuses for PRs touching more than 300
files (e.g. vendor bumps). Claude was then told no diff was supplied.

Move the git-based diff computation, introduced for the test-skipping
step, into .github/actions/evetest-run-suite/pr-diff.sh and use it from
both the workflow and the watcher. Vendored code stays excluded and is
summarised in pr-vendored.txt.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa milan-zededa added the testing New test or test framework changes label Nov 3, 2026
@github-actions
github-actions Bot requested a review from europaul November 3, 2026 16:15
@rene
rene merged commit 0d9fde1 into lf-edge:master Nov 4, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants