Skip to content

evetest-pr: consume a CODEOWNER's /evetest comment once it starts a run - #7030

Merged
rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-consume-comment
Nov 4, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-consume-comment

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

PR Gate used the latest /evetest comment of a CODEOWNER regardless of its
age, so every later push of the PR re-triggered evetest from the same stale
comment, and the comment stayed visible forever.

PR Gate now ignores minimized comments and passes the node ID of the comment it
acted on to evetest-pr. Once that workflow starts a run (or finds one already
testing the same commit), it reacts to the comment with a rocket and collapses
it as resolved. A further run requires a new /evetest comment, or a PR
approval. A request made for a commit that is no longer the PR head is left for
the next gate run.

PR dependencies

None.

How to test and validate this PR

CI workflow change, not covered by an automated test. On a PR with a green build:

  1. As a CODEOWNER, comment /evetest all. Expect evetest to start, the comment
    to get a rocket reaction and to be collapsed as resolved.
  2. Push a new commit without commenting. Expect the "Ready for evetest" status
    to stay pending (unless the PR is approved) and no evetest run.
  3. Comment /evetest again. Expect a new run and the new comment consumed.

Changelog notes

None. No user-facing changes (CI tooling only).

PR Backports

Not to be backported on its own: all evetest workflow files will be backported
together once they work reliably.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

The device and documentation boxes do not apply: this only changes GitHub
workflows.

🤖 Generated with Claude Code

@milan-zededa milan-zededa added the testing New test or test framework changes label Nov 4, 2026
@github-actions
github-actions Bot requested a review from europaul November 4, 2026 13:23
PR Gate used the latest /evetest comment of a CODEOWNER regardless of
its age, so every later push of the PR re-triggered evetest from the
same stale comment, and the comment stayed visible forever.

PR Gate now ignores minimized comments and passes the node ID of the
comment it acted on to evetest-pr. Once that workflow starts a run (or
finds one already testing the same commit), it reacts to the comment
with a rocket and collapses it as resolved. A further run requires a
new /evetest comment, or a PR approval.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa
milan-zededa force-pushed the evetest-consume-comment branch from 10845bc to bf030bb Compare November 4, 2026 13:36
@rene
rene merged commit e97d6a4 into lf-edge:master Nov 4, 2026
40 of 41 checks passed
@milan-zededa
milan-zededa deleted the evetest-consume-comment branch November 4, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants