Repository navigation
Fix SBOM generation: bump pillar in modules left on an unreachable commit - #7041
Conversation
Commit 2cb4f79 pinned pkg/edgeview, pkg/newlog, pkg/kube/kube-init and pkg/wwan/mmagent to pillar v0.0.0-20261103090849-1d275e6fd307, a commit of the PR branch that was rebased before merge and so never reached master. proxy.golang.org returns 404 for it, which breaks go-sources-and-licenses in the SBOM/sources step of the Publish workflow. The previous bump (7cea040) skipped these four modules: go get cannot upgrade from a version it cannot fetch, and bump-eve-pillar runs it through find -execdir, which ignores the failure. Point them at a master commit with go mod edit first, then run the usual go get -u, go mod tidy and go mod vendor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
The bump targets ran go get through find -execdir, which ignores the exit status of the commands it runs, so a module that could not be bumped was skipped silently while make reported success. That is how 7cea040 left four modules pinned to an unreachable pillar commit. Bump each tracked module that requires the dependency, keep going past failures, and exit non-zero at the end with the list of modules that failed. Matching on the require line also skips the module of the dependency itself (go get always failed in pkg/pillar for bump-eve-pillar) and untracked copies such as .claude/worktrees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
The pillar bump in 7cea040 changed the vendor tree of pkg/recovertpm, so its image tag changed, but pkg/debug/Dockerfile still referenced the old one and make check-docker-hashes-consistency failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Updating the eve-recovertpm image in pkg/debug changed the eve-debug image tag, which pkg/installer/Dockerfile pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7041 +/- ##
==========================================
+ Coverage 29.06% 29.57% +0.50%
==========================================
Files 548 559 +11
Lines 98971 100566 +1595
==========================================
+ Hits 28768 29738 +970
- Misses 67932 68604 +672
+ Partials 2271 2224 -47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TestDiagSuite: failure analysisTestDiagOutputFailureClaude's conclusionRoot cause analysisLive evidence: Ledger check: No prior entry in PR #7041 relatedness: The diff is purely dependency/build plumbing — a |
TestLPSSuite: failure analysisTestRadioSilenceFailureClaude's conclusionRoot causeLive evidence shows the device actually rebooted successfully — it just took longer than the test's fixed timeout. The controller issued the reboot at 12:57:29, the app halted by 12:58:39, and the device's new boot (confirmed via live SSH: This is a known, recurring issue: the exact same "device reboots fine but exceeds the fixed 5-minute PR #7041's diff is purely a vendor bump (eve-api/eve-libs pillar pointer bumps) and |
TestAppsSuite: failure analysisTestVMAppPurgeAfterPowerCycleFailureClaude's conclusionGood, that confirms the known issue dates back to run #1 (2026-10-29) and recurs every night since. I have a solid root cause now. Root causeThis is not a pillar/zedmanager bug — it's the device going network-unreachable for ~16 minutes at exactly the moment the test needed to read a file. Adam's access log for this device ( This shares its mechanism (not its specific symptom) with the extensive cascade of "SDN VM/gRPC tunnel becomes unreachable" failures already logged elsewhere in tonight's run ( Regarding PR #7041: its diff only touches the |
TestApplicationConnectivitySuite: failure analysisTestSwitchNIDeletedWithAppsAttachedFailureClaude's conclusionRoot causeLive evidence shows This is the identical signature already catalogued in PR #7041's diff only touches the |
TestDeviceConnectivitySuite: failure analysisTestPNACWithoutProxyFailureClaude's conclusionRoot causeLive evidence shows this wasn't actually a networking/ACL problem: This matches a known, recurring infra issue in PR #7041's diff is purely dependency/Dockerfile-base-image bumps (Makefile, |
TestSecuritySuite: failure analysisTestAppVTPMIdentitySurvivesRebootsFailureClaude's conclusionRoot causeThis is the same domainmgr/vtpmd launch-race bug previously diagnosed in the ledger (2026-11-02, run #5), recurring here with a slightly different symptom. Live This is the same underlying mechanism as the 2026-11-02 (run #5) ledger entry for this same test — a race between TestAppVTPMProtectedFailurePreservesStateFailureClaude's conclusionConfirmed — PR #7041 only touches Makefile bump-target refactoring, Root causeLive This shares the same root cause as the |
TestNodeClusterResilienceSuite: failure analysisTestDNIDandBackupDNIDFailureClaude's conclusionRoot causeLive evidence confirms this is the exact same bug previously diagnosed in the ledger. On edge-dev1 (the DNID for app This is a known, recurring issue per The PR under test (#7041) only touches the TestVMAppPurgeDuringFailoverFailureClaude's conclusionThis confirms edge-dev1 (the designated node) is unreachable/suspect — consistent with the deliberate failover scenario and matching the exact prior-run mechanism. I have enough evidence. Root causeThis is the same known, recurring zedmanager/zedkube "purge-after-failover" deadlock already seen for This failure was already investigated earlier in this same run (see the prior write-up embedded in PR #7041 only touches |
TestNodeClusterSuite: failure analysisTestClusterVMAppFailureClaude's conclusionRoot causeLive inspection shows the app itself is stuck, not the harness/SDN: This matches, but isn't byte-identical to, a standing bug already logged 3× in |
Description
The Publish workflow on master has been failing in the "Collect and push SBOM and sources" step since #5644. The failure is in
go-sources-and-licenses:Commit 2cb4f79 pinned
pkg/edgeview,pkg/newlog,pkg/kube/kube-initandpkg/wwan/mmagentto pillar at1d275e6fd307. That commit is on the PR branch before the rebase, so it never reached master, and proxy.golang.org returns 404 for it. Builds still pass because they use the vendored copy. Only the sources collection downloads module zips.The follow-up bump in 7cea040 skipped exactly those four modules.
go get -ucannot upgrade from a version it cannot fetch (invalid version: unknown revision 1d275e6fd307).bump-eve-pillarruns it throughfind -execdir, which ignores the exit status of the commands it runs, somakestill reported success.This PR has four commits:
go mod edit, then runs the usualgo get -u,go mod tidyandgo mod vendor. They now pinv0.0.0-20261105091144-7cea040d89f9. In eachgo.modonly the pillar line changes.bump-*targets. It bumps each tracked module that requires the dependency, keeps going past failures, and at the end exits non-zero with the list of modules that failed. Matching on the require line also skips the dependency's own module (go getfailed inpkg/pillaron everybump-eve-pillarrun) and untracked copies such as.claude/worktrees.pkg/recovertpm, so its image tag changed.pkg/debug/Dockerfilestill referenced the old tag, andmake check-docker-hashes-consistencyfailed on master.eve-debugimage tag, whichpkg/installer/Dockerfilepins.How to test and validate this PR
Tested locally:
tools/collect-sources.shruns in CI:go build ./...with-mod=vendorin the four modules passes.make bump-eve-pillarwith the new Makefile, run on master, exits 2:make check-docker-hashes-consistencypasses. On master it fails withpkg/debug/Dockerfile uses lfedge/eve-recovertpm:f39bf74c... but c1a132f0... is built in this repo.After merge, the Publish workflow on master should pass the "Collect and push SBOM and sources" step.
Changelog notes
None. Build tooling only.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't check them. Build tooling and vendor change only: no device testing or documentation needed. It was verified locally with the SBOM sources walk CI runs.
🤖 Generated with Claude Code