Skip to content

Bump eve/pkg/pillar in all subprojects - #7044

Merged
rene merged 2 commits into
lf-edge:masterfrom
rucoder:rucoder/pubsub-pillar-bump
Nov 5, 2026
Merged

rene merged 2 commits into
lf-edge:masterfrom
rucoder:rucoder/pubsub-pillar-bump

Conversation

@rucoder

@rucoder rucoder commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Follow-up to #7037, as agreed there. The pillar bump was kept out of that PR so that the modules pin a commit on master.

This PR moves every module that requires pkg/pillar to master c22104d6c, the merge of #7037. It was done with make bump-eve-pillar.

  • pkg/newlog, pkg/edgeview, pkg/wwan/mmagent, pkg/kube/kube-init, pkg/installer, pkg/recovertpm and pkg/vtpm vendor pkg/pillar/pubsub. They get the pubsub: marshal and compress once for all subscribers #7037 changes:
    • published values marshalled and compressed once for all subscribers;
    • []byte compared with bytes.Equal in cmp.Equal;
    • a persistent subscription no longer decodes again what it has just loaded;
    • the corrected allocation counters.
  • evetest and evetest/sdn/vm do not vendor; they only take the new version.

The second commit, from tools/bump-and-commit.sh, updates the package hashes this changes. pkg/debug now builds from the new eve-recovertpm image, and pkg/installer from the new eve-debug image.

Only pkg/pillar moves: no other dependency changes in any go.mod or go.sum. The vendored changes are all under pkg/pillar/pubsub, plus modules.txt. The wire protocol is the same, so these components and pillar keep talking whatever their versions.

How to test and validate this PR

  • All nine modules build: go build -mod=vendor ./..., or plain go build ./... for evetest.
  • Tests pass natively for pkg/newlog, pkg/edgeview and pkg/kube/kube-init; go vet passes for evetest.
  • pkg/vtpm/swtpm-vtpm fails the same way on master with the host's swtpm 0.7.3, so make test in docker is the reference for it.
  • On a device: newlog, edgeview and the wwan agent connect to pillar's publications as before.

Changelog notes

No user-facing changes.

PR Backports

  • 17.0-stable: No.
  • 16.0-stable: No.
  • 14.5-stable: No.
  • 13.4-stable: No.

Checklist

  • I've provided a proper description

  • I've added the proper documentation

  • I've tested my PR on amd64 device

  • I've tested my PR on arm64 device

  • I've written the test verification instructions

  • I've set the proper labels to this PR

  • I've checked the boxes above, or I've provided a good reason why I didn't check them. Only vendored code changes, so no documentation applies. The pubsub changes were tested on amd64 in pubsub: marshal and compress once for all subscribers #7037; this PR only builds them into the other components.

Move the modules which require pkg/pillar to master c22104d, the
merge of lf-edge#7037: published values marshalled and compressed once for
all subscribers, byte slices compared with bytes.Equal, the values a
persistent subscription has loaded not decoded again when the
publisher resends them at start, and the corrected allocation
counters. pkg/newlog, pkg/edgeview, pkg/wwan/mmagent,
pkg/kube/kube-init, pkg/installer, pkg/recovertpm and pkg/vtpm vendor
pkg/pillar/pubsub; evetest and its SDN VM do not vendor and only take
the new version.

Done with make bump-eve-pillar. Only pkg/pillar moves; the vendored
changes are in pubsub, and the wire protocol is the same.

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Update all package hashes after a change to a package that others are built from.

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.58%. Comparing base (c22104d) to head (db97ff5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
+ Coverage   29.08%   29.58%   +0.49%     
==========================================
  Files         548      559      +11     
  Lines       99033   100628    +1595     
==========================================
+ Hits        28808    29773     +965     
- Misses      67950    68626     +676     
+ Partials     2275     2229      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

evetest skip decision

This PR only bumps pkg/pillar version pointers (go.mod/go.sum) in the modules that
vendor pkg/pillar/pubsub — pkg/newlog, pkg/edgeview, pkg/wwan/mmagent,
pkg/kube/kube-init, pkg/installer, pkg/recovertpm, pkg/vtpm/swtpm-vtpm, plus
evetest/evetest/sdn/vm (which only take the new version), and updates the resulting
image base-hashes. No pkg/pillar source changes ship in this PR — the actual pubsub
behavior change (marshal/compress once, bytes.Equal comparisons, skip re-decoding
persisted values, corrected allocation counters) already merged to master in #7037.

So the only components whose built behavior actually changes here are the ones that
vendor a fresh copy of pillar/pubsub: newlogd, edgeview, mmagent (wwan/cellular),
kube-init, the installer, recovertpm, and swtpm-vtpm.

Kept as the most direct coverage of those components:

  • TestSecuritySuite's TestAppVTPM* tests (swtpm-vtpm)
  • TestTelemetrySuite's TestDeviceLogs/TestWorkingConfig/TestFaultyConfig/TestEmptyConfig/TestInvalidBase64Config/TestRemoteLogLevelNone/TestKernelPanicReport, and TestAppLogs (newlogd pipeline)
  • TestBootstrapWithInstaller (exercises the installer image)
  • TestKonvertSuite and TestKubeRegistrationSuite (both directly exercise kube-init bring-up/registration; TestKubeRegistrationClusterSetup literally references pkg/kube/kube-init/components/registration.go)

Skipped — unrelated (check A): entire suites that don't touch any of the bumped
components at all (networking/NI, zedagent info-retry, downloader, diag, USB hardware,
LPS/profile, config-item limits, PCI passback errors, port scanning, storage/volumes,
and the normal base-OS TestUpgradeSuite), plus TestDeviceConnectivitySuite (its only
nominally-relevant test, TestCellularConnectivity, is currently an unimplemented stub).
Also individual subtests inside otherwise-kept suites whose purpose is plainly unrelated
(app lifecycle/VNC/cgroups/halt/purge mechanics in TestAppsSuite, non-installer
bootstrap flavors in TestBootstrapSuite, apparmor/vcom/cert-rotation/vault-key-mode in
TestSecuritySuite, and info/metrics/hardware-inventory reporting in
TestTelemetrySuite).

Skipped — redundant duplicates (check B): TestNodeClusterSuite and
TestNodeClusterResilienceSuite. Both stand up eve-k clusters the same way
TestKonvertSuite/TestKubeRegistrationSuite already do, but their actual purpose is
unrelated functional/resilience testing (app networking, purge, port scan, tie-breaker,
replica recovery) — the cluster bring-up they share with the kept suites is incidental.

An engineer can comment /evetest all to force the full suite to run instead, or
/evetest <name> <name> ... to run only specific tests/suites.

@rene
rene merged commit d87216a into lf-edge:master Nov 5, 2026
60 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants