Repository navigation
Bump eve/pkg/pillar in all subprojects - #7044
Conversation
Move the modules which require pkg/pillar to master c22104d, the merge of lf-edge#7037: published values marshalled and compressed once for all subscribers, byte slices compared with bytes.Equal, the values a persistent subscription has loaded not decoded again when the publisher resends them at start, and the corrected allocation counters. pkg/newlog, pkg/edgeview, pkg/wwan/mmagent, pkg/kube/kube-init, pkg/installer, pkg/recovertpm and pkg/vtpm vendor pkg/pillar/pubsub; evetest and its SDN VM do not vendor and only take the new version. Done with make bump-eve-pillar. Only pkg/pillar moves; the vendored changes are in pubsub, and the wire protocol is the same. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Update all package hashes after a change to a package that others are built from. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
+ Coverage 29.08% 29.58% +0.49%
==========================================
Files 548 559 +11
Lines 99033 100628 +1595
==========================================
+ Hits 28808 29773 +965
- Misses 67950 68626 +676
+ Partials 2275 2229 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
evetest skip decisionThis PR only bumps So the only components whose built behavior actually changes here are the ones that Kept as the most direct coverage of those components:
Skipped — unrelated (check A): entire suites that don't touch any of the bumped Skipped — redundant duplicates (check B): An engineer can comment |
Description
Follow-up to #7037, as agreed there. The pillar bump was kept out of that PR so that the modules pin a commit on master.
This PR moves every module that requires
pkg/pillarto masterc22104d6c, the merge of #7037. It was done withmake bump-eve-pillar.pkg/newlog,pkg/edgeview,pkg/wwan/mmagent,pkg/kube/kube-init,pkg/installer,pkg/recovertpmandpkg/vtpmvendorpkg/pillar/pubsub. They get the pubsub: marshal and compress once for all subscribers #7037 changes:[]bytecompared withbytes.Equalincmp.Equal;evetestandevetest/sdn/vmdo not vendor; they only take the new version.The second commit, from
tools/bump-and-commit.sh, updates the package hashes this changes.pkg/debugnow builds from the neweve-recovertpmimage, andpkg/installerfrom the neweve-debugimage.Only
pkg/pillarmoves: no other dependency changes in anygo.modorgo.sum. The vendored changes are all underpkg/pillar/pubsub, plusmodules.txt. The wire protocol is the same, so these components and pillar keep talking whatever their versions.How to test and validate this PR
go build -mod=vendor ./..., or plaingo build ./...for evetest.pkg/newlog,pkg/edgeviewandpkg/kube/kube-init;go vetpasses for evetest.pkg/vtpm/swtpm-vtpmfails the same way on master with the host's swtpm 0.7.3, somake testin docker is the reference for it.Changelog notes
No user-facing changes.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't check them. Only vendored code changes, so no documentation applies. The pubsub changes were tested on amd64 in pubsub: marshal and compress once for all subscribers #7037; this PR only builds them into the other components.