Skip to content

evetest: extend config-confirm wait while a reboot is expected - #7079

Merged
rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-confirm-wait-reboot
Nov 13, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-confirm-wait-reboot

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

A config that makes EVE reboot, such as withdrawing a node's cluster
config, is often confirmed only after the device boots again: the reboot
can come before zedagent publishes its next metrics. The 2-minute
confirm wait in EdgeDevice.ApplyConfig then expires during the boot.

This was seen in TestNodeClusterSuite/TestClusterToSingleConversion:
edge-dev3 fetched the config at 16:32:26, rebooted at 16:32:58 without
publishing metrics in between, and the first post-boot metrics (uptime
89s, about 16:34:27) already reported LastProcessedConfig equal to the
config timestamp. The test had failed at 16:34:26, one second earlier,
even though the conversion itself succeeded.

ApplyConfig now adds deviceRebootTimeout to the confirm wait while a
reboot declared with ExpectAdditionalReboots has not been observed
yet, as Setup already does for the config-fetch wait of a rebooted
device. When no reboot is pending, the wait is unchanged.

How to test and validate this PR

Run the cluster conversion test, which applies a config that makes the
device reboot and waits for its confirmation:

make evetest NAME=TestClusterToSingleConversion

The test should no longer fail with failed to confirm the latest config ... timed out waiting for LastProcessedConfig while the device reboots.
In the log, the confirm wait is followed by a Device ... rebooted
message and then Device ... confirmed the latest config.

Changelog notes

None (test framework only).

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

Documentation: the ApplyConfig doc comment is updated; no other docs
describe the confirm timeout. Not yet tested on a device: the failure
was diagnosed on a paused evetest run, and the change is built and vetted.

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

@milan-zededa milan-zededa added stable Should be backported to stable release(s) testing New test or test framework changes labels Nov 11, 2026
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.54%. Comparing base (d5a49ec) to head (03ffcb1).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7079      +/-   ##
==========================================
+ Coverage   29.08%   29.54%   +0.45%     
==========================================
  Files         550      561      +11     
  Lines       99453   101048    +1595     
==========================================
+ Hits        28926    29854     +928     
- Misses      68243    68958     +715     
+ Partials     2284     2236      -48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

A config that makes EVE reboot, such as withdrawing a node's cluster
config, is often confirmed only after the device boots again: the reboot
can come before zedagent publishes its next metrics. The 2-minute
confirm wait in ApplyConfig then expires during the boot, as seen in
TestClusterToSingleConversion, where the confirmation arrived a second
after the deadline.

Add deviceRebootTimeout to the wait while a reboot declared with
ExpectAdditionalReboots has not been observed yet, as Setup already does
for the config-fetch wait of a rebooted device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa
milan-zededa force-pushed the evetest-confirm-wait-reboot branch from e3d8993 to 03ffcb1 Compare November 11, 2026 14:46
@rene
rene merged commit 6342f69 into lf-edge:master Nov 13, 2026
45 of 47 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Evetest: Claude chose to skip 22 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary.

Comment /evetest all to run the full suite, or /evetest <name> <name> ... to run only specific tests/suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s) testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants