Repository navigation
evetest: extend config-confirm wait while a reboot is expected - #7079
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7079 +/- ##
==========================================
+ Coverage 29.08% 29.54% +0.45%
==========================================
Files 550 561 +11
Lines 99453 101048 +1595
==========================================
+ Hits 28926 29854 +928
- Misses 68243 68958 +715
+ Partials 2284 2236 -48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A config that makes EVE reboot, such as withdrawing a node's cluster config, is often confirmed only after the device boots again: the reboot can come before zedagent publishes its next metrics. The 2-minute confirm wait in ApplyConfig then expires during the boot, as seen in TestClusterToSingleConversion, where the confirmation arrived a second after the deadline. Add deviceRebootTimeout to the wait while a reboot declared with ExpectAdditionalReboots has not been observed yet, as Setup already does for the config-fetch wait of a rebooted device. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
evetest-confirm-wait-reboot
branch
from
November 11, 2026 14:46
e3d8993 to
03ffcb1
Compare
rene
approved these changes
Nov 13, 2026
Contributor
|
Evetest: Claude chose to skip 22 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary. Comment |
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A config that makes EVE reboot, such as withdrawing a node's cluster
config, is often confirmed only after the device boots again: the reboot
can come before zedagent publishes its next metrics. The 2-minute
confirm wait in
EdgeDevice.ApplyConfigthen expires during the boot.This was seen in
TestNodeClusterSuite/TestClusterToSingleConversion:edge-dev3 fetched the config at 16:32:26, rebooted at 16:32:58 without
publishing metrics in between, and the first post-boot metrics (uptime
89s, about 16:34:27) already reported
LastProcessedConfigequal to theconfig timestamp. The test had failed at 16:34:26, one second earlier,
even though the conversion itself succeeded.
ApplyConfignow addsdeviceRebootTimeoutto the confirm wait while areboot declared with
ExpectAdditionalRebootshas not been observedyet, as
Setupalready does for the config-fetch wait of a rebooteddevice. When no reboot is pending, the wait is unchanged.
How to test and validate this PR
Run the cluster conversion test, which applies a config that makes the
device reboot and waits for its confirmation:
The test should no longer fail with
failed to confirm the latest config ... timed out waiting for LastProcessedConfigwhile the device reboots.In the log, the confirm wait is followed by a
Device ... rebootedmessage and then
Device ... confirmed the latest config.Changelog notes
None (test framework only).
PR Backports
Checklist
Documentation: the
ApplyConfigdoc comment is updated; no other docsdescribe the confirm timeout. Not yet tested on a device: the failure
was diagnosed on a paused evetest run, and the change is built and vetted.
check them.
🤖 Generated with Claude Code