Repository navigation
evetest: don't reuse devices from a cluster with a tie-breaker - #7085
Merged
Merged
Conversation
EVE does not support changing or removing the tie-breaker of a formed cluster. Its setup (node labels, cordon, replica counts, nodeSelectors) stays in place after a later config drops or moves the tie-breaker, and after the tie-breaker leaves the cluster. A test that reuses such devices inherits it whatever tie-breaker it asks for. The tie-breaker's labels stay on it, or a node that rejoins gets no label, and in both cases longhorn-manager never runs on that node, so volumes cannot be created or attached there. This fails TestClusterVMApp after TestTieBreakerCluster and TestClusterToSingleConversion, and TestClusterPVCGCDeletesOnlyOrphans after TestDNIDandBackupDNID. The next test's tie-breaker is only known once it builds its cluster config, after its devices are set up, so devices whose last cluster config named a tie-breaker are not reused at all. Each affected test then forms its cluster on fresh devices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7085 +/- ##
==========================================
+ Coverage 29.08% 29.57% +0.48%
==========================================
Files 550 561 +11
Lines 99453 101048 +1595
==========================================
+ Hits 28926 29880 +954
- Misses 68243 68927 +684
+ Partials 2284 2241 -43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rene
approved these changes
Nov 13, 2026
Contributor
|
Evetest: Claude chose to skip 25 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary. Comment |
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EVE does not support changing or removing the tie-breaker of a formed
cluster. Its setup (node labels, cordon, replica counts, nodeSelectors)
stays in place after a later config drops or moves the tie-breaker, and
after the tie-breaker leaves the cluster. When evetest reuses such
devices for the next test, that test inherits the old tie-breaker setup
whatever tie-breaker it asks for. Either the old tie-breaker keeps its
labels, or a node that rejoins gets no label. In both cases
longhorn-manager never runs on that node, so volumes cannot be created
or attached there.
This is behind recurring nightly failures:
TestClusterToSingleConversion (failed in each of the last 5 nightlies)
The next test's tie-breaker is only known once it builds its cluster
config, after its devices are set up. So evetest now does not reuse
devices whose last cluster config named a tie-breaker at all, and the
affected tests form their clusters on fresh devices.
How to test and validate this PR
Run the cluster test suite, or just a test pair from above in sequence
(e.g. a suite with TestDNIDandBackupDNID followed by
TestClusterPVCGCDeletesOnlyOrphans). The evetest log shows
Device "..." was in a cluster with a tie-breaker; not reusing devicesbefore the second test, which then passes on fresh devices.
Changelog notes
No user-facing changes.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them. Test-framework-only change, no documentation needed; it
will be validated by the nightly evetest runs.
🤖 Generated with Claude Code