Skip to content

evetest/Makefile: use common linuxkit cache - #7089

Merged
milan-zededa merged 1 commit into
lf-edge:masterfrom
christoph-zededa:evetest_lkt_cache_fix
Nov 13, 2026
Merged

milan-zededa merged 1 commit into
lf-edge:masterfrom
christoph-zededa:evetest_lkt_cache_fix

Conversation

@christoph-zededa

@christoph-zededa christoph-zededa commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

make evetest gave the evetest container a linuxkit cache of its own,
~/.evetest/linuxkit-cache. Mount the common one, ~/.linuxkit/cache,
instead.

A test that traces the EVE host (TestVGAPassthroughNoHostAccess) runs
eve-tools/bpftrace-compiler in the container. The compiler builds the image
of its compile VM from eve-tools/bpftrace-compiler/root/Dockerfile, which
has a stage FROM lfedge/eve-bpftrace:<hash of pkg/bpftrace>. With the
common cache it finds a locally built pkg/bpftrace there. That is needed
whenever the image is not on Docker Hub yet, e.g. on a branch that changes
pkg/bpftrace.

The separate cache was introduced by #6609 (edbadfc, "evetest: let tests
run bpftrace-compiler in the container").

How to test and validate this PR

  1. Take a tree whose lfedge/eve-bpftrace:<hash> (the tag named in
    eve-tools/bpftrace-compiler/root/Dockerfile) is not on Docker Hub, e.g.
    a branch that changes pkg/bpftrace.
  2. make pkg/bpftrace builds it into ~/.linuxkit/cache.
  3. make evetest NAME=TestVGAPassthroughNoHostAccess

Without this PR the compiler in the container does not see the local build
and cannot pull the image either. With it, the tracer is compiled with the
local build and the test gets to run it.

make -n -C evetest evetest NAME=TestVGAPassthroughNoHostAccess prints the
docker run command, which now has
-v '<home>/.linuxkit/cache:/root/.linuxkit/cache'.

Changelog notes

No user-facing changes.

PR Backports

All four LTS branches have the same mount: evetest was synced to them from
master after #6609 (in #6833, #6842, #6873 and #6899). The commit applies
cleanly to each.

  • 17.0-stable: To be backported.
  • 16.0-stable: To be backported.
  • 14.5-stable: To be backported.
  • 13.4-stable: To be backported.

Checklist

  • I've provided a proper description
  • I've added the proper documentation (not yet: the "All-in-One Mode" section of evetest/README.md still names ~/.evetest/linuxkit-cache)
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR (stable)

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

@christoph-zededa christoph-zededa added the stable Should be backported to stable release(s) label Nov 11, 2026
instead of the one from ~/evetest/linuxkit-cache

this way the cache includes the pkg/bpftrace which is needed
when running a test with bpftrace-compiler and pkg/bpftrace
is not yet uploaded to docker hub

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.55%. Comparing base (d5a49ec) to head (1d79446).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7089      +/-   ##
==========================================
+ Coverage   29.08%   29.55%   +0.47%     
==========================================
  Files         550      561      +11     
  Lines       99453   101048    +1595     
==========================================
+ Hits        28926    29866     +940     
- Misses      68243    68944     +701     
+ Partials     2284     2238      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christoph-zededa
christoph-zededa marked this pull request as ready for review November 12, 2026 14:34
@milan-zededa
milan-zededa merged commit 68a389c into lf-edge:master Nov 13, 2026
47 of 49 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Evetest: Claude chose to skip 40 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary.

Comment /evetest all to run the full suite, or /evetest <name> <name> ... to run only specific tests/suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants