Repository navigation
evetest/Makefile: use common linuxkit cache - #7089
Merged
milan-zededa merged 1 commit intoNov 13, 2026
Merged
Conversation
github-actions
Bot
requested review from
eriknordmark,
europaul,
milan-zededa and
rucoder
November 11, 2026 17:58
instead of the one from ~/evetest/linuxkit-cache this way the cache includes the pkg/bpftrace which is needed when running a test with bpftrace-compiler and pkg/bpftrace is not yet uploaded to docker hub Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
evetest_lkt_cache_fix
branch
from
November 11, 2026 18:05
59fba74 to
1d79446
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7089 +/- ##
==========================================
+ Coverage 29.08% 29.55% +0.47%
==========================================
Files 550 561 +11
Lines 99453 101048 +1595
==========================================
+ Hits 28926 29866 +940
- Misses 68243 68944 +701
+ Partials 2284 2238 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christoph-zededa
marked this pull request as ready for review
November 12, 2026 14:34
milan-zededa
approved these changes
Nov 13, 2026
Contributor
|
Evetest: Claude chose to skip 40 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary. Comment |
This was referenced Nov 13, 2026
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make evetestgave the evetest container a linuxkit cache of its own,~/.evetest/linuxkit-cache. Mount the common one,~/.linuxkit/cache,instead.
A test that traces the EVE host (
TestVGAPassthroughNoHostAccess) runseve-tools/bpftrace-compilerin the container. The compiler builds the imageof its compile VM from
eve-tools/bpftrace-compiler/root/Dockerfile, whichhas a stage
FROM lfedge/eve-bpftrace:<hash of pkg/bpftrace>. With thecommon cache it finds a locally built
pkg/bpftracethere. That is neededwhenever the image is not on Docker Hub yet, e.g. on a branch that changes
pkg/bpftrace.The separate cache was introduced by #6609 (edbadfc, "evetest: let tests
run bpftrace-compiler in the container").
How to test and validate this PR
lfedge/eve-bpftrace:<hash>(the tag named ineve-tools/bpftrace-compiler/root/Dockerfile) is not on Docker Hub, e.g.a branch that changes
pkg/bpftrace.make pkg/bpftracebuilds it into~/.linuxkit/cache.make evetest NAME=TestVGAPassthroughNoHostAccessWithout this PR the compiler in the container does not see the local build
and cannot pull the image either. With it, the tracer is compiled with the
local build and the test gets to run it.
make -n -C evetest evetest NAME=TestVGAPassthroughNoHostAccessprints thedocker runcommand, which now has-v '<home>/.linuxkit/cache:/root/.linuxkit/cache'.Changelog notes
No user-facing changes.
PR Backports
All four LTS branches have the same mount: evetest was synced to them from
master after #6609 (in #6833, #6842, #6873 and #6899). The commit applies
cleanly to each.
Checklist
evetest/README.mdstill names~/.evetest/linuxkit-cache)stable)And the last but not least:
check them.
🤖 Generated with Claude Code