Skip to content

evetest: use adam 0.0.87 - #7099

Merged
milan-zededa merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-adam-0.0.87
Nov 12, 2026
Merged

milan-zededa merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-adam-0.0.87

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Brings the latest Adam patch (lf-edge/adam#164), which stops the log
stream from silently losing entries. Previously Adam dropped published
entries once a subscriber's 100-entry channel was full, so a large log
chunk uploaded by the device (e.g. the hundreds of lines of a kernel
panic stack trace) could lose its tail even though it was stored. Adam
also flushed the stream response before subscribing, so entries
published in between could be missed.
Affected tests in the telemetry suite: TestKernelPanicReport and
TestDeviceLogs. Both failed intermittently because log lines present
in Adam's store never reached the live log watch.

It also picks up lf-edge/adam#162, which writes device JSON files
atomically. Before, an attest request could read an empty options.json
while a nonce request was rewriting it and fail with
getDeviceOptions failed to unmarshal: unexpected end of JSON input
(HTTP 500), which could delay onboarding past evetest's 2-minute config wait.

How to test and validate this PR

Run the evetest telemetry suite (TestTelemetrySuite), in particular
TestKernelPanicReport and TestDeviceLogs. Both pass with Adam 0.0.87.

Changelog notes

None. Test framework change only, no user-facing changes.

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't check them.

🤖 Generated with Claude Code

Brings the latest Adam patch (lf-edge/adam#164), which stops the log
stream from silently losing entries. Previously Adam dropped published
entries once a subscriber's 100-entry channel was full, so a large log
chunk uploaded by the device (e.g. the hundreds of lines of a kernel
panic stack trace) could lose its tail even though it was stored. Adam
also flushed the stream response before subscribing, so entries
published in between could be missed.

Affected tests in the telemetry suite: TestKernelPanicReport and
TestDeviceLogs. Both failed intermittently because log lines present
in Adam's store never reached the live log watch.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa milan-zededa added stable Should be backported to stable release(s) testing New test or test framework changes labels Nov 12, 2026
@milan-zededa
milan-zededa requested a review from rene November 12, 2026 11:44
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.57%. Comparing base (6a1353e) to head (d1527c8).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7099      +/-   ##
==========================================
+ Coverage   29.08%   29.57%   +0.49%     
==========================================
  Files         550      561      +11     
  Lines       99453   101048    +1595     
==========================================
+ Hits        28926    29888     +962     
- Misses      68243    68922     +679     
+ Partials     2284     2238      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

Evetest: Claude chose to skip 26 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary.

Comment /evetest all to run the full suite, or /evetest <name> <name> ... to run only specific tests/suites.

@milan-zededa

Copy link
Copy Markdown
Contributor Author

Merging and will check errors in the evetest-nightly run tomorrow.

@milan-zededa
milan-zededa merged commit fc84110 into lf-edge:master Nov 12, 2026
75 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s) testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants