Repository navigation
evetest: load the EVE image from the broker for netboot artifacts - #7103
Merged
Merged
Conversation
Since EVE images are staged on the broker once per host, the runner's Docker no longer holds the PR build image up front. buildNetbootArtifacts pulled it with a plain docker pull, which fails for PR images that are published to no registry (TestBootstrapWithNetworkBoot: "pull access denied for evebuild/pr"). Use pullEVEImage instead, which falls back to loading the image from the broker when the registry pull fails, as the EVE upgrade path already does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7103 +/- ##
==========================================
+ Coverage 29.06% 29.54% +0.47%
==========================================
Files 550 561 +11
Lines 99453 101048 +1595
==========================================
+ Hits 28909 29855 +946
- Misses 68263 68957 +694
+ Partials 2281 2236 -45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rene
approved these changes
Nov 13, 2026
Contributor
|
Evetest: Claude chose to skip 27 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary. Comment |
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since EVE images are staged on the evetest brokers once per host, a suite job's
Docker no longer holds the PR build image up front.
buildNetbootArtifacts(used by
TestBootstrapWithNetworkBoot) still pulled the image with a plaindocker pull, which fails for PR images because they are published to noregistry:
Use
pullEVEImageinstead. It tries the registry first and falls back toloading the image from the broker, as the EVE upgrade path already does.
PR dependencies
None. Follow-up to #7043.
How to test and validate this PR
Run
TestBootstrapWithNetworkBoot(orTestBootstrapSuite) from anevetest-prrun of a PR whose EVE image is not published to a registry, and check that the
netboot artifacts are built instead of failing with "pull access denied".
go build,go vetandgofmtare clean; the test itself needs the brokerenvironment and was not run locally.
Changelog notes
None. No user-facing changes (evetest only).
PR Backports
Checklist
check them.
🤖 Generated with Claude Code