Skip to content

evetest: load the EVE image from the broker for netboot artifacts - #7103

Merged
rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-netboot-pull-eve-image
Nov 13, 2026
Merged

rene merged 1 commit into
lf-edge:masterfrom
milan-zededa:evetest-netboot-pull-eve-image

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Since EVE images are staged on the evetest brokers once per host, a suite job's
Docker no longer holds the PR build image up front. buildNetbootArtifacts
(used by TestBootstrapWithNetworkBoot) still pulled the image with a plain
docker pull, which fails for PR images because they are published to no
registry:

netboot.go:43: Failed to pull EVE image evebuild/pr:0.0.0-pr7099-d1527c87-kvm-amd64 for netboot artifacts:
  pull access denied for evebuild/pr, repository does not exist or may require 'docker login'

Use pullEVEImage instead. It tries the registry first and falls back to
loading the image from the broker, as the EVE upgrade path already does.

PR dependencies

None. Follow-up to #7043.

How to test and validate this PR

Run TestBootstrapWithNetworkBoot (or TestBootstrapSuite) from an evetest-pr
run of a PR whose EVE image is not published to a registry, and check that the
netboot artifacts are built instead of failing with "pull access denied".
go build, go vet and gofmt are clean; the test itself needs the broker
environment and was not run locally.

Changelog notes

None. No user-facing changes (evetest only).

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

🤖 Generated with Claude Code

Since EVE images are staged on the broker once per host, the runner's
Docker no longer holds the PR build image up front. buildNetbootArtifacts
pulled it with a plain docker pull, which fails for PR images that are
published to no registry (TestBootstrapWithNetworkBoot: "pull access
denied for evebuild/pr").

Use pullEVEImage instead, which falls back to loading the image from the
broker when the registry pull fails, as the EVE upgrade path already does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
@milan-zededa milan-zededa added stable Should be backported to stable release(s) testing New test or test framework changes labels Nov 12, 2026
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.54%. Comparing base (8e09559) to head (0536907).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7103      +/-   ##
==========================================
+ Coverage   29.06%   29.54%   +0.47%     
==========================================
  Files         550      561      +11     
  Lines       99453   101048    +1595     
==========================================
+ Hits        28909    29855     +946     
- Misses      68263    68957     +694     
+ Partials     2281     2236      -45     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rene
rene merged commit d91d407 into lf-edge:master Nov 13, 2026
44 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Evetest: Claude chose to skip 27 test/suite name(s) as unrelated to or redundant for this PR. Which ones and why: run summary.

Comment /evetest all to run the full suite, or /evetest <name> <name> ... to run only specific tests/suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable Should be backported to stable release(s) testing New test or test framework changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants