Skip to content

Infra tab cycle keys - #6

Merged
lfdominguez merged 2 commits into
lfdominguez:mainfrom
aqu1ntero:infra-tab-cycle-keys
Nov 9, 2026
Merged

lfdominguez merged 2 commits into
lfdominguez:mainfrom
aqu1ntero:infra-tab-cycle-keys

Conversation

@aqu1ntero

Copy link
Copy Markdown
Contributor

What and why

In the infra workspace, Ctrl+Shift+Page Down / Page Up (⌘ on macOS) go to the next / previous tab of the organization on screen. From the last tab they go round to the first. From a tab of another organization they go to the first / last one. They follow the workspace's Ctrl+Shift pattern, and Page Up/Down don't change with Shift, so they work on any keyboard layout.

Known issue, not fixed here

Ctrl+Shift+1…9 never matches on Linux. Gio's xkb names a key by its shifted keysym, so Ctrl+Shift+1 arrives as ! on a US layout. A non-ASCII one (ES Shift+3 ·) arrives as no key.Event at all. It is left as a ponytail: comment in internal/infra/gui.go, with the upgrade path: a patched Gio in third_party/ that names a digit key by its level-0 keysym while Ctrl+Shift is held.

Checklist

  • Tests cover the change (TestGMCycleTab: next, previous, wrap, from another org's tab, an org without tabs; TestGMShortcut's filter count). qa cover was not run locally: CI runs it
  • go run ./cmd/qa mutate -file <file> ./internal/<pkg>: not run locally
  • Docs (reference/keys.mdx, servers/overview.mdx) updated
  • User-visible changes under ## [Unreleased] in CHANGELOG.md
  • Examples stay generic

🤖 Generated with Claude Code

aqu1ntero and others added 2 commits November 8, 2026 10:05
The next or previous tab of the organization on screen, wrapping round;
from another organization's tab, its first or last. Docs and changelog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gio's xkb names the key by its shifted keysym ("!" for 1 on a US layout,
nothing for a non-ASCII one), so the tab digits never reach the filter.
A ponytail comment with the upgrade path: a patched Gio in third_party.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f4b8e81-23f0-4830-a9c1-e1085557d4ee
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

✅ Coverage passes

Changed lines Packages Tests
100.0% · 15 of 15 (min 98%) 14 of 14 at their floor ✅ pass

Changed files

File Covered
internal/infra/gui.go 15 / 15 · 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩
Packages (coverage against its floor)
Package Coverage Floor
internal/claude 99.2% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/clip 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 100% ✅
internal/fzf 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 100% ✅
internal/infra 99.1% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/kanban 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 100% ✅
internal/links 99.9% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/orgs 99.5% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/sshc 96.7% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 95% ✅
internal/sshconfig 97.7% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 97% ✅
internal/term 99.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 98% ✅
internal/tty 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 100% ✅
internal/ui 99.1% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/ui/kit 99.8% 🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜ 99% ✅
internal/vault 100.0% 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 100% ✅

go run ./cmd/qa cover since origin/main · updated on every push

CI run for a41bd2d

@lfdominguez
lfdominguez merged commit d75e9ba into lfdominguez:main Nov 9, 2026
2 checks passed
lfdominguez added a commit to aqu1ntero/desk that referenced this pull request Nov 9, 2026
Keep both Unreleased entries in CHANGELOG.md (Added from lfdominguez#6, Fixed from lfdominguez#5).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants