Repository navigation
Put the Visual Studio LLVM ahead of the image LLVM on Windows CI. - #545
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the Visual Studio LLVM ahead of the image LLVM on Windows CI.
The
windows-2025-vs2026runner image 20261116.315 updates Visual Studio to 18.12, whose MSVC STL 14.52 rejects any Clang older than 22:The clang-cl presets name a bare
clang-cl, which resolves to the image's standalone LLVM atC:\Program Files\LLVM\bin(Clang 20.1.8). That folder precedes the Visual Studio LLVM on PATH (msvc-dev-cmdappends the latter). The prior image (20261103.298, STL 14.51) accepts Clang 20, so jobs pass or fail depending on which image version the runner has during the rollout. Same label, same minute:win-clangcl-release-staticwin-clangcl-release-staticA step after
msvc-dev-cmdprepends the Visual Studio LLVM ($VCINSTALLDIR\Tools\Llvm\<x64|ARM64>\bin) toGITHUB_PATH. The step fails ifclang-cl.exeis absent and logsclang-cl --version. The Visual Studio Clang ships with the STL it pairs with, so this holds on both image versions. Visual Studio 18 locally ships Clang 22.1.3.Regenerated
ci-expanded.ymlmust be committed to system, database, network, node, server and explorer.