Skip to content

Put the Visual Studio LLVM ahead of the image LLVM on Windows CI. - #545

Merged
pmienk merged 1 commit into
libbitcoin:masterfrom
evoskuil:master
Nov 18, 2026
Merged

pmienk merged 1 commit into
libbitcoin:masterfrom
evoskuil:master

Conversation

@evoskuil

Copy link
Copy Markdown
Member

Put the Visual Studio LLVM ahead of the image LLVM on Windows CI.

The windows-2025-vs2026 runner image 20261116.315 updates Visual Studio to 18.12, whose MSVC STL 14.52 rejects any Clang older than 22:

yvals_core.h(923): error STL1000: Unexpected compiler version, expected Clang 22 or newer.

The clang-cl presets name a bare clang-cl, which resolves to the image's standalone LLVM at C:\Program Files\LLVM\bin (Clang 20.1.8). That folder precedes the Visual Studio LLVM on PATH (msvc-dev-cmd appends the latter). The prior image (20261103.298, STL 14.51) accepts Clang 20, so jobs pass or fail depending on which image version the runner has during the rollout. Same label, same minute:

Job Image STL Clang Result
database win-clangcl-release-static 20261103.298 14.51.36231 20.1.8 pass
explorer win-clangcl-release-static 20261116.315 14.52.37025 20.1.8 fail

A step after msvc-dev-cmd prepends the Visual Studio LLVM ($VCINSTALLDIR\Tools\Llvm\<x64|ARM64>\bin) to GITHUB_PATH. The step fails if clang-cl.exe is absent and logs clang-cl --version. The Visual Studio Clang ships with the STL it pairs with, so this holds on both image versions. Visual Studio 18 locally ships Clang 22.1.3.

Regenerated ci-expanded.yml must be committed to system, database, network, node, server and explorer.

@evoskuil evoskuil added this to the 4.0 milestone Nov 18, 2026
@evoskuil
evoskuil requested a review from pmienk November 18, 2026 23:23
@evoskuil evoskuil added the build label Nov 18, 2026
@pmienk
pmienk merged commit 238509f into libbitcoin:master Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants