Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/bitcoin/node/settings.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class BCN_API settings
uint32_t threads;
bool delay_inbound;
bool thread_priority;
bool memory_priority;
bool provide_blocks;
bool require_blocks;
bool provide_witness;
Expand Down Expand Up @@ -86,7 +85,6 @@ class BCN_API settings
virtual network::steady_clock::duration compact_timeout() const NOEXCEPT;
virtual network::wall_clock::duration currency_window() const NOEXCEPT;
virtual network::processing_priority thread_priority_() const NOEXCEPT;
virtual network::memory_priority memory_priority_() const NOEXCEPT;
};

} // namespace node
Expand Down
9 changes: 0 additions & 9 deletions src/settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ settings::settings() NOEXCEPT
threads{ 0 },
delay_inbound{ true },
thread_priority{ true },
memory_priority{ true },
provide_blocks{ true },
require_blocks{ true },
provide_witness{ true },
Expand Down Expand Up @@ -207,13 +206,5 @@ network::processing_priority settings::thread_priority_() const NOEXCEPT
network::processing_priority::medium;
}

network::memory_priority settings::memory_priority_() const NOEXCEPT
{
// highest is "normal" (os default), so false is a behavior change.
// highest is the OS default, so far low does not have a noticeable effect.
return memory_priority ? network::memory_priority::highest :
network::memory_priority::low;
}

} // namespace node
} // namespace libbitcoin
2 changes: 0 additions & 2 deletions test/settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ BC_AUTO_TEST_CASE(settings__node__default_context__expected)
BC_REQUIRE(node.network == system::chain::selection::none);
BC_REQUIRE_EQUAL(node.threads, 0_u32);
BC_REQUIRE_EQUAL(node.delay_inbound, true);
BC_REQUIRE_EQUAL(node.memory_priority, true);
BC_REQUIRE_EQUAL(node.thread_priority, true);
BC_REQUIRE_EQUAL(node.provide_blocks, true);
BC_REQUIRE_EQUAL(node.require_blocks, true);
Expand Down Expand Up @@ -78,7 +77,6 @@ BC_AUTO_TEST_CASE(settings__node__default_context__expected)
BC_REQUIRE(node.sample_period() == steady_clock::duration(seconds(10)));
BC_REQUIRE(node.currency_window() == steady_clock::duration(minutes(1440)));
BC_REQUIRE(node.thread_priority_() == network::processing_priority::high);
BC_REQUIRE(node.memory_priority_() == network::memory_priority::highest);
}

BC_AUTO_TEST_CASE(settings__node__mainnet_context__expected)
Expand Down
Loading