Repository navigation
Encode the rest block hash by height text as a hash. - #1188
Merged
Merged
Conversation
The .hex form of /rest/blockhashbyheight returned the hash bytes in serialized order. bitcoind returns the hash in display order, the same string as the .json form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /rest/blockhashbyheight/<height>.hexreturnedencode_base16(hash), the serialized byte order. bitcoind returns the display order (GetHex()), which is the string the.jsonform already returns, so the two text forms disagreed for every block. The.binform is unchanged.The unit test expected the serialized order. It now expects
block5, the display string the other tests in the file use.