Repository navigation
fix(theme): validate against lich's current theme template - #50
Merged
Merged
Conversation
validate.mjs reads its token sets off skills/theme/template.json, a copy taken before lich 0.53.0 made the app tokens tone-pass and tone-wait required (lichdotdev/lich#617). It called a current theme's tones unknown and passed a theme without them that lich rejects on import. The template is now refreshed from lich at tests/lich-ref by refresh-fixtures.sh, and the CI drift job diffs it with the fixtures, so the next token lich adds reaches the validator by moving the ref. The skill's token count and role table follow.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate.mjs derived its app tokens from a template.json copied before lich 0.53.0 made
tone-pass/tone-waitrequired (lichdotdev/lich#617): current packs (rose-pine, catppuccin, eldritch, moonfly, oceanic-next) failed withunknown app color, and a pack without the tones passed although lich rejects it withapp.tone-wait is required.tests/theme-validate.test.mjs: a theme with the tones passes, one withouttone-waitfails with lich's message (both failed before the fix).tests/refresh-fixtures.shnow vendorsthemes/template.jsonfrom lich attests/lich-ref; the CI drift job diffs it with the fixtures — one source, lich's own template.tone-pass/tone-waitin the role table with theminLichVersionhint.node --test tests/*.test.mjs: 330 pass.