Repository navigation
fix(mod): tell a session's own label apart with lich whoami - #64
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #62. The self-command mod took lich's control_session refusal as "this is the session itself" by matching its words, which have no contract. lich#700 adds
lich whoami --jsonand accepts a session id wherever a session is named; the mod now asks whoami (only on a refused command) and compares the target to its id, label or name, case-insensitively. When whoami fails (lich before it), only the LICH_SESSION_ID counts.Docs name lich 0.64 as the first with whoami: to confirm against the actual release before merging.
node --test: 380 pass; claude plugin validate passes; claude plugin test: 31 pass.