Skip to content

fix(native): stop the eglInitialize flake in the render tests #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omartelo merged 4 commits into from
Oct 16, 2026
Merged

fix(native): stop the eglInitialize flake in the render tests #776

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
967033c
ci: temporary loop measuring the native EGL flake
omartelo Oct 16, 2026
4268d0a
ci: log Xvfb errors and peak X connections in the loop
omartelo Oct 16, 2026
cf8da27
ci: compare Xvfb -noreset against baseline in the loop
omartelo Oct 16, 2026
0f785c8
ci(native): keep Xvfb from resetting between render tests
omartelo Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,14 @@ jobs:

# The render tests skip where no GPU answers, which on a laptop is a
# shrug and here would be a gate that checks nothing: a skip fails the job.
# -noreset: each headless window holds the only X connection and drops it
# on Release, so Xvfb regenerates about 60 times a run, and an
# eglInitialize that lands mid-reset fails xcb_connect (1 run in 5 did).
- name: go test
env:
LIBGL_ALWAYS_SOFTWARE: "1"
run: |
xvfb-run -a go test -v ./... > test.log 2>&1 || { cat test.log; exit 1; }
xvfb-run -a -s "-noreset -screen 0 1280x1024x24" go test -v ./... > test.log 2>&1 || { cat test.log; exit 1; }
grep -E '^(ok|FAIL|---)' test.log
if grep -q 'no headless GPU' test.log; then
echo "::error::render tests skipped: no headless GPU under Xvfb"
Expand Down
Loading