Repository navigation
fix(store): open the workspace database in WAL mode - #804
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The store opened SQLite with the default rollback journal and
synchronous=FULL, so every commit created, synced and deleted a journal file. On Windows that costs ~37ms a commit: the timings from #802 putinternal/storeat 150s on the Windows runner against 8s on Linux, and it alone set the wall time of the whole backend suite. lich itself pays the same on every write on Windows.opennow addsjournal_mode(WAL)andsynchronous(NORMAL)to the DSN. Commits append tolich.db-wal; a power loss can drop the last commits, never corrupt the file.TestOpenCommitsWithoutAJournalFilePerWritepins both pragmas (fails on main withdelete/2).internal/storewent from 8s to 3.3s; on Windows, read this PR's Backend tests step against the ~185s median (the per-package table arrives with ci: report the slowest Go packages and tests in every job summary #802).docs/ceilings.md: the database is now three files while lich runs, so copyinglich.dbalone off a running lich misses recent commits.No CHANGELOG entry: nothing a user sees changes beyond writes getting cheaper.