Repository navigation
test(drop): run past a small search budget instead of writing 50,001 files - #807
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestResolveRefusesTwinsSplitByTheBudgetandTestResolveFindsShallowSiblingBeforeNoisehave to run the search past its budget, and the budget was themaxEntries = 50_000constant, so each wrote 50,001 files. On the Windows runner that took 38s and 37s (the timings table from #802, run 39056236000), most ofinternal/drop's 111s; on Linux about 1s each.maxEntriesis now a packagevarthe tests replace, the same idiom ashomeDirandsandboxAvailablein the same file. Production still uses 50,000.smallBudget(t)sets it to 16 for one test and restores it. Both tests call it; their loops still write budget + 1 entries and their assertions are unchanged, so only the fixture size moves.Checked: both tests now take 0.00s locally, and breaking the
if scan.budget > 0guard on purpose still failsTestResolveRefusesTwinsSplitByTheBudgetwith the wrong twin.