Repository navigation
test(project): run the tests that touch no process-wide state in parallel - #810
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/projectsets the Windows suite's wall time (77s in the #808 run) without a single slow test: the slowest is 2.3s, and the rest is ~250 tests at ~0.3s each running one after another. The repo had not.Parallel()anywhere.t.Parallel()as their first line. Nothing else changes in them.t.Setenv(mostlyXDG_DATA_HOME, which panics undert.Parallel),captureLog(swaps the globalslogdefault, so a parallel test's warning would land in its buffer) andisolateGitConfig. Serial top-level tests finish before any paused parallel test resumes, so they never overlap.Measured on Linux at
GOMAXPROCS=4(the Windows runner's core count), three runs each: 4.2s → 2.7s.-race -count=20at 4 procs and again at-parallel=16: no failure, no race.go vetclean for linux and windows. The Windows number comes from this PR's Timings table.