Repository navigation
test(cli): run the suite in parallel - #814
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/clitakes 15s on every OS (#813 run) and, withterminalandrelayparallel, shares the floor of the Linux and macOS backend suites. Its tests mostly wait on timers, one after another.t.Parallel()as their first line. Nothing else changes in them.rage_test.gostay serial: they set environment variables. The package holds no other process-wide state: noos.Stdoutswap, no fixed port, no env read in the product code.Stressed:
-race -count=30atGOMAXPROCS=4and-count=30 -parallel=64atGOMAXPROCS=2(starved on purpose), ~6,450 executions each, no failure and no race. Locally at 4 procs: 15s → ~5s.go vetclean for linux, windows and darwin.