Skip to content

fix(native): reread the patch notes when the interface language changes - #817

Merged
omartelo merged 1 commit into
mainfrom
fix/native-patch-notes-follow-language
Oct 17, 2026
Merged

omartelo merged 1 commit into
mainfrom
fix/native-patch-notes-follow-language

Conversation

@omartelo

Copy link
Copy Markdown
Collaborator

The native window reads the release notes once and keeps them. Switching the interface language redrew the group names in the new language but left the items in the one they were read in, so What's new showed Portuguese headings over English notes.

keepLanguage now rereads the notes for the new language. The backend already served the right translation; only the native cache was stale.

Test

  • TestChoosingALanguageRereadsThePatchNotes failed before the fix and passes now (-count=20). The fake backend in sidebar_prefs_test.go answers patchnotes.Current with the locale it was asked for.
  • native/: go test ./..., go vet ./..., gofmt -l . clean.

The web window already rereads on a locale change (UpdatesSettings depends on locale).

@omartelo
omartelo merged commit 74443f1 into main Oct 17, 2026
10 checks passed
@omartelo
omartelo deleted the fix/native-patch-notes-follow-language branch October 17, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant