Repository navigation
fix(native): reread the patch notes when the interface language changes - #817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native window reads the release notes once and keeps them. Switching the interface language redrew the group names in the new language but left the items in the one they were read in, so What's new showed Portuguese headings over English notes.
keepLanguagenow rereads the notes for the new language. The backend already served the right translation; only the native cache was stale.Test
TestChoosingALanguageRereadsThePatchNotesfailed before the fix and passes now (-count=20). The fake backend insidebar_prefs_test.goanswerspatchnotes.Currentwith the locale it was asked for.native/:go test ./...,go vet ./...,gofmt -l .clean.The web window already rereads on a locale change (
UpdatesSettingsdepends onlocale).