Repository navigation
feat(native): label the checks that gate a pull request's merge - #820
Merged
Merged
Conversation
gh pr view --json statusCheckRollup carries no isRequired, so the detail asks GitHub's GraphQL for it once the pull request reports checks, and the native Checks tab marks those rows Required, as GitHub's own list does.
…checks # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The native Pulls screen's Checks tab marks the checks that gate the merge with a Required pill, the way GitHub's own checks list does.
How
gh pr view --json statusCheckRollupdoes not carryisRequired(it takes the pull request as an argument), soPullRequestDetailmakes one GraphQL call for it, only when the PR reports checks. It covers both rulesets and classic branch protection.testruns in bothciandnative).CheckItemgainsrequired, mirrored innative/lichclientandfrontend/src/lib/api-types.ts. The web UI does not render it (maintenance mode).paletteChip; the word lands in all 7 native locales.Notes
testchecks (ciandnative) read required, which is GitHub's answer: themainruleset requires contexttestwith no app pinned.pr-handoff.test.tsfixture gainsrequired: false: the contract changed (new required field onCheckItem).Verification
go test ./internal/project/(3 new tests),go vet ./internal/...,gofmtnative/:gofmt,go vet ./...,go test ./...biome ci .,tsc -b,vitest run src/lib/pulls-shotof the tab (it cannot navigate to a PR's Checks tab).