Repository navigation
fix(native): draw the desktop's cursor on Wayland - #835
Merged
Merged
Conversation
Bumps lichdotdev/gio to c389a6eb. The window now sets its cursor through wp_cursor_shape_v1, so the compositor draws it in its own theme, size and scale; niri keeps the theme in its config and never handed it to lich through XCURSOR_THEME. Without the protocol, the window reloads its cursor theme when its scale changes, which stops the cursor jumping on entering the window from a monitor with a smaller scale than the largest one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
lichdotdev/gio(branchdrop-event) toc389a6eb, which fixes two cursor bugs in the native window on Wayland, reported on niri with noctalia:XCURSOR_THEME/XCURSOR_SIZEin its environment. niri keeps the theme in its own config, so lich fell back to the default xcursor theme. The window now sets its cursor throughwp_cursor_shape_v1: it names a shape and the compositor draws it in its own theme, size and scale. niri and Hyprland both have the protocol.Verification
native/:gofmt -l .,go vet ./...andgo test ./...clean.app/os_wayland.goplus generated protocol code), with no unit test.