Repository navigation
test(project): start the waitdelay deadline once the grandchild holds the pipe - #838
Merged
Merged
Conversation
… the pipe TestSubprocessBudgetOutlivesAGrandchild gave the call a fixed 200ms. On Windows that can run out before the test binary has started twice (child, then grandchild): the context killed the child before it spawned the grandchild, Output returned at once, and the cleanup waited ten seconds for a grandchild that never existed: "the grandchild did not exit once released" (os-tests on #834, run 39273705110). The grandchild now writes a holding file once it holds the pipe, and the test cancels the context at that moment and measures Output from there. The test changes because it asserted something the contract never promised: that two process spawns fit in 200ms. Measured on Linux with the child sleeping 1s before spawning the grandchild: 3/3 failures before with the same message, 3/3 passes after. Without cmd.WaitDelay the test still fails (Output blocked 9.99s past the deadline), and 50/50 runs pass with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestSubprocessBudgetOutlivesAGrandchild gave the call a fixed 200ms. On
Windows that can run out before the test binary has started twice (child,
then grandchild): the context killed the child before it spawned the
grandchild, Output returned at once, and the cleanup waited ten seconds for
a grandchild that never existed: "the grandchild did not exit once
released" (os-tests on #834, run 39273705110).
The grandchild now writes a holding file once it holds the pipe, and the
test cancels the context at that moment and measures Output from there.
The test changes because it asserted something the contract never
promised: that two process spawns fit in 200ms.
Measured on Linux with the child sleeping 1s before spawning the
grandchild: 3/3 failures before with the same message, 3/3 passes after.
Without cmd.WaitDelay the test still fails (Output blocked 9.99s past the
deadline), and 50/50 runs pass with it.