Repository navigation
fix(native): name the window lich so the dock groups it under lich's icon - #839
Merged
Merged
Conversation
…icon Gio takes the Wayland app_id and the X11 WM_CLASS from app.ID, which defaults to the binary's name. lich-native matches no .desktop entry, so GNOME docks (reported on Pop!_OS) showed the native window as a separate app with a generic icon beside lich's own. build/linux/lich.desktop claims "lich" (StartupWMClass=lich), the class the web window already uses. The dev window takes "lichdev" under LICH_DEV, as the web one does, so compositor rules for the daily driver never capture it. On Windows, Gio uses the same ID as the window class name; nothing else registers "lich".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user on Pop!_OS reported that the native window opens as a separate dock entry with a generic icon instead of under lich's.
Gio takes the Wayland
app_idand the X11WM_CLASSfromapp.ID, which defaults to the binary's name,lich-native. No.desktopentry claims that;build/linux/lich.desktopclaimslich(StartupWMClass=lich), the class the web window already uses.lich-nativesetsapp.IDtolich, orlichdevunderLICH_DEV, mirroring the web window'swindowTargetso compositor rules for the daily driver never capture the dev window.lich.Verification
gofmt,go vet ./cmd/lich-native/and the newTestWindowClasspass.os_wayland.go(xdg_toplevel_set_app_id(ID)) andos_x11.go(XSetClassHintwithID).