Repository navigation
fix(native): keep the active first tab's left fillet past the window buttons - #841
Merged
Merged
Conversation
…buttons With the sidebar collapsed and the window's buttons on the left (macOS's traffic lights, or a GNOME button-layout with them there), the strip starts after the brand instead of at the island's edge. The active first tab's left fillet draws a radius left of the strip, and the strip's clip cut it off, so the tab met the island with a square foot on one side. The pushed strip now starts a radius after the brand and its clip reaches back over that room.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #840. With the sidebar collapsed and the window's buttons on the left (macOS's traffic lights, or GNOME's
button-layoutputting them there), the tab strip starts after the brand rather than at the terminal island's edge. The active first tab's left fillet is drawn a radius left of the strip, and the strip's clip cut it off.stripStart: a strip pushed past the island's edge starts a fillet radius after the brand; otherwise it starts at the island's edge as before.No CHANGELOG entry: the title bar from #840 has not shipped yet.
Verification
TestStripStartLeavesTheFilletRoomfailed before the change and passes after.native/:gofmt,go vet ./...,go test ./...clean.button-layoutfrom the portal or a Mac.