Repository navigation
Use MPC/Halley–Marcus photometry by default for comets - #39
Draft
ColinOrionChandler wants to merge 4 commits into
Draft
ColinOrionChandler wants to merge 4 commits into
ColinOrionChandler wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 84.70% 89.24% +4.54%
==========================================
Files 5 6 +1
Lines 1327 1488 +161
==========================================
+ Hits 1124 1328 +204
+ Misses 203 160 -43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comet runs currently use the distance-only magnitude law and ignore the MPC comet brightness exponent. This makes
ponder --cometandrun_ponder(..., comet=True)use MPC H/G plus the Schleicher–Marcus (Halley–Marcus) dust phase function inside Sorcha, before noise and detection cuts.--comet-photometry legacypreserves the distance-only law; asteroid photometry stays unchanged.Depends on dirac-institute/sorcha-addons#42. Ponder temporarily pins the tested add-on commit
7cfc0e9f173cc194379991f75d468c4cc482cd13in its runtime dependencies, so installing this branch obtains the new model automatically. The integration CI installs Ponder normally and verifies the model is present. Replace this source pin with the released minimum version before publishing a Ponder package release. Both PRs remain drafts; no merge or release is part of this update.comet_G_assumedflag; missing H stays unknown.photometry.json.This photometry branch is based directly on
mainand incorporates its subsequent ASSIST >= 1.2.3 requirement. It excludes the earlier update-mode, NEO, reporting, and generated-data changes oncodex/mpc-halley-marcus; that branch remains an intact development snapshot.Validation: 57 tests passed with a fresh installation of this branch and its pinned add-on, including real Sorcha magnitude and selection checks; Black 23.7.0, isort 5.12.0, pyproject validation, and
git diff --checkpassed. The installed local commit hook could not start because Python 3.11 is unavailable, so the formatters and tests were run directly with the isolated Python 3.13 environment.Scientific scope: dust-dominated total magnitudes, catalog H treated as zero-phase H_r, fixed Rubin colors, no aperture/point-source recalibration or outburst/gas model. Steep catalog G extrapolated to distant inactive comets can yield extreme faint magnitudes; no separate nucleus contribution is included. The calculation is numerically tested, but accuracy against observed comet photometry has not yet been established. README and
docs/comet-photometry.mddocument the equation, migration, selection settings, and scientific limits. For completeness-focused searches, the guide recommends considering retention of all geometrically eligible comets, including faint and unknown predictions, without magnitude-based exclusion. It also gives a repeatable independent-model and observational validation checklist.Independent spot check (2026-11-08): 12 comet/epoch cases reproduce Horizons within printed rounding with matched parameters and no phase term; Kete 1.1.0 agrees to floating-point precision. Eight saved Sorcha rows replay exactly, and substituting Horizons geometry changes predictions by less than 0.001 mag. The HM curve agrees with Lowell’s published table to sbpy’s storage precision. Large MPC/JPL H/G disagreements remain, including a 19.6-mag phase-free offset for P/2009 WX51; these model checks do not establish observational accuracy. The comparison CSV, software summary, and selected source records are preserved under
docs/validation/.Documentation update validation: local Markdown links, archived comparison integrity, and
git diff --checkpassed; the existing real-Sorcha test for retention with selection disabled and rejection after a magnitude cut passed (1 test). The local commit hook failed while installing its formatter environment because the home filesystem was full; this documentation commit used the direct checks above.