Skip to content

fix: fix ReferenceError control not defined - #3469

Open
52cyb wants to merge 1 commit into
masterfrom
fix/password-control-id
Open

fix: fix ReferenceError control not defined#3469
52cyb wants to merge 1 commit into
masterfrom
fix/password-control-id

Conversation

@52cyb

@52cyb 52cyb commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix ReferenceError: control is not defined in src/plugin-accounts/qml/PasswordLayout.qml by adding the missing id: control to the D.ItemDelegate delegate.

Change

  • Add one line id: control after delegate: D.ItemDelegate {
  • Fixes the z binding that references control on the password change dialog rows
  • Restores the z-order highlight for password error alert rows and removes the ReferenceError log noise

Related Issue

DDE-223

PMS: TASK-392413

Summary by Sourcery

Bug Fixes:

  • Fix the password change dialog’s undefined delegate reference, restoring correct error-row highlighting and eliminating related runtime ReferenceError logs.

1. Add missing id: control to the D.ItemDelegate delegate in PasswordLayout.qml
2. This fixes ReferenceError: control is not defined in the z binding
3. Restore the z-order highlight behavior for password error alert rows

Log: Fixed ReferenceError log noise in the password change dialog

Influence:
1. Open the password change dialog and verify no ReferenceError in logs
2. Trigger a password alert and verify the error row z-order highlight works
3. Verify all password input rows render correctly

fix: 修复PasswordLayout中control未定义问题

1. 在PasswordLayout.qml的D.ItemDelegate委托中补充缺失的id: control
2. 修复z绑定中ReferenceError: control is not defined报错
3. 恢复密码错误提示行的z-order高亮效果

Log: 修复修改密码对话框的ReferenceError日志噪音

Influence:
1. 打开修改密码对话框,确认日志中无ReferenceError报错
2. 触发密码告警,验证错误行的z-order高亮生效
3. 验证所有密码输入行显示正常

PMS: TASK-392413
@52cyb
52cyb marked this pull request as draft September 7, 2026 11:18
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the missing control ID to the password dialog’s D.ItemDelegate, allowing its existing z-order binding to resolve and restoring password error-row highlighting without ReferenceError log noise.

File-Level Changes

Change Details Files
Defines the delegate identifier required by an existing z-order binding.
  • Adds id: control to the password-change dialog row delegate.
  • Resolves the runtime ReferenceError and restores error-row highlight stacking.
src/plugin-accounts/qml/PasswordLayout.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@52cyb
52cyb marked this pull request as ready for review September 8, 2026 03:38
@deepin-bot

deepin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 6.1.106
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3497

@deepin-bot

deepin-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 6.1.107
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants