fix: fix ReferenceError control not defined - #3469
Open
52cyb wants to merge 1 commit into
Open
Conversation
1. Add missing id: control to the D.ItemDelegate delegate in PasswordLayout.qml 2. This fixes ReferenceError: control is not defined in the z binding 3. Restore the z-order highlight behavior for password error alert rows Log: Fixed ReferenceError log noise in the password change dialog Influence: 1. Open the password change dialog and verify no ReferenceError in logs 2. Trigger a password alert and verify the error row z-order highlight works 3. Verify all password input rows render correctly fix: 修复PasswordLayout中control未定义问题 1. 在PasswordLayout.qml的D.ItemDelegate委托中补充缺失的id: control 2. 修复z绑定中ReferenceError: control is not defined报错 3. 恢复密码错误提示行的z-order高亮效果 Log: 修复修改密码对话框的ReferenceError日志噪音 Influence: 1. 打开修改密码对话框,确认日志中无ReferenceError报错 2. 触发密码告警,验证错误行的z-order高亮生效 3. 验证所有密码输入行显示正常 PMS: TASK-392413
52cyb
marked this pull request as draft
September 7, 2026 11:18
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds the missing File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
52cyb
marked this pull request as ready for review
September 8, 2026 03:38
|
TAG Bot New tag: 6.1.106 |
|
TAG Bot New tag: 6.1.107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ReferenceError: control is not definedinsrc/plugin-accounts/qml/PasswordLayout.qmlby adding the missingid: controlto theD.ItemDelegatedelegate.Change
id: controlafterdelegate: D.ItemDelegate {controlon the password change dialog rowsRelated Issue
DDE-223
PMS: TASK-392413
Summary by Sourcery
Bug Fixes: