sync: from linuxdeepin/dde-session-shell - #540
deepin-ci-robot wants to merge 1 commit into
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#91
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSynchronizes the passkey authentication UI with the upstream source by configuring the security-key prompt as a non-wrapping, non-elided label. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/session-widgets/auth_passkey.cpp" line_range="40-41" />
<code_context>
/* 文案提示 */
m_textLabel->setText(tr("Please plug in the security key"));
- m_textLabel->setWordWrap(true);
+ m_textLabel->setWordWrap(false);
+ m_textLabel->setElideMode(Qt::ElideNone);
/* 旋转提示和文案提示布局 */
</code_context>
<issue_to_address>
**issue (bug_risk):** When the localized prompt or an authentication result is wider than the available 280-pixel passkey widget, disabling wrapping while using `Qt::ElideNone` causes the label to clip the text rather than display it completely. The fixed margins, spinner, and authentication-state label leave less width than the label's natural size.
**Triggers:** When a long translation or backend-provided authentication result is shown.
**Suggested fix:** Give the label enough layout space or use a non-wrapping presentation that preserves the full text, such as horizontal scrolling or an appropriate tooltip, instead of allowing it to be clipped.
</issue_to_address>| m_textLabel->setWordWrap(false); | ||
| m_textLabel->setElideMode(Qt::ElideNone); |
There was a problem hiding this comment.
issue (bug_risk): When the localized prompt or an authentication result is wider than the available 280-pixel passkey widget, disabling wrapping while using Qt::ElideNone causes the label to clip the text rather than display it completely. The fixed margins, spinner, and authentication-state label leave less width than the label's natural size.
Triggers: When a long translation or backend-provided authentication result is shown.
Suggested fix: Give the label enough layout space or use a non-wrapping presentation that preserves the full text, such as horizontal scrolling or an appropriate tooltip, instead of allowing it to be clipped.
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： [] 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： [] 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例无需修改，代码实现正确。 本报告由 AI 代码审查工具自动生成 |
1 participant
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#91
Summary by Sourcery
Bug Fixes: