fix: change cross-app accessed dconfig item from private to public#1678
Open
18202781743 wants to merge 1 commit into
Open
fix: change cross-app accessed dconfig item from private to public#167818202781743 wants to merge 1 commit into
18202781743 wants to merge 1 commit into
Conversation
The following config item is accessed by applications other than the owner appId, so its visibility should be public instead of private: - noTaskGrouping: accessed by dde-control-center (dock module) Serial bumped from 0 to 1. PMS: BUG-000000
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts dde-shell dock task manager dconfig definitions so cross-application consumers can read certain settings by changing their permission from private to public, aligning with updated identity-based access logic in dde-dconfig-daemon. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Within the updated dconfig file, consider only changing the specific keys that are actually read by other apps from private to public and leaving purely dock-local settings private, to minimize the cross-app configuration surface being exposed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Within the updated dconfig file, consider only changing the specific keys that are actually read by other apps from private to public and leaving purely dock-local settings private, to minimize the cross-app configuration surface being exposed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // 当前代码已足够完善，无需修改。保持原有结构即可：
"noTaskGrouping": {
"value": false,
"serial": 1,
"flags": [],
"name": "No Task-Grouping",
"name[zh_CN]": "禁用任务分组",
"description": "Disable Taskbar Icon Grouping by Application",
"description[zh_CN]": "禁用任务栏图标按应用分组",
"permissions": "readwrite",
"visibility": "public"
}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: change cross-app accessed dconfig item from private to public
变更说明
具体修改的配置项
技术方案简述
关联的其他 PR
Summary by Sourcery
Bug Fixes: