test(protocols): stabilize wlr screencopy fixture

[zorowk]

The screencopy protocol test relied on wlroots implicit 1280x720 output while its fixture documentation and client expected 1920x1080.

• Disable the implicit headless output and create the documented 1920x1080 fixture output.
• Derive layer buffer and capture-region dimensions from the configure event.
• Format the C client and update the Chinese test documentation.

A deterministic single output keeps the captured frame dimensions aligned with the rendered source buffer.

Summary by Sourcery

Make the wlr screencopy protocol test deterministic by controlling its headless output fixture and deriving capture dimensions from protocol events.

Bug Fixes:

• Stabilize the wlr screencopy protocol fixture by using a deterministic single 1920×1080 headless output and sizing buffers and capture regions from layer-surface configuration.

Enhancements:

• Improve screencopy test diagnostics for output rendering and frame failures.
• Preserve an explicitly configured WLR_XWAYLAND environment value and ensure the test depends on the bundled Xwayland executable.

Documentation:

• Update the Chinese screencopy test documentation to describe the explicit output fixture and configure-derived dimensions.

Tests:

• Refine the screencopy protocol test setup and client coverage for full-output and regional captures.

Chores:

• Format and reorganize the screencopy test client code and shared test state definitions.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zorowk

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide

This PR stabilizes the wlroots screencopy protocol test by replacing the implicit 1280×720 headless output with a deterministic single 1920×1080 fixture, deriving client buffers and capture regions from layer configuration, and adding explicit XWayland test setup plus detailed rendering diagnostics.

Sequence diagram for configuration-driven screencopy capture

sequenceDiagram
    participant Fixture as Test fixture
    participant Compositor
    participant Client as Screencopy client
    participant Output as 1920x1080 output

    Fixture->>Compositor: Create one 1920x1080 headless output
    Compositor-->>Output: wl_output geometry and mode
    Client->>Compositor: Create layer surface
    Compositor-->>Client: configure(width, height)
    Client->>Client: Allocate buffer from configure dimensions
    Client->>Compositor: Commit layer surface buffer
    Client->>Compositor: zwlr_screencopy_manager_v1_capture_output
    Compositor-->>Client: Frame dimensions match configured output
    Client->>Compositor: zwlr_screencopy_frame_v1_copy
    Compositor-->>Client: Captured frame

Loading

File-Level Changes

Change	Details	Files
Make the screencopy test use an explicit, deterministic headless output fixture.	Disable wlroots’ implicit headless output for this test. Create one 1920×1080 output during protocol-test setup. Build the test XWayland executable before protocol tests and configure WLR_XWAYLAND explicitly, while preserving externally supplied settings.	tests/protocols/wlr-screencopy-unstable-v1/CMakeLists.txt tests/protocols/wlr-screencopy-unstable-v1/setup.cpp tests/protocols/framework/ProtocolTest.cmake src/core/treeland.cpp
Drive layer rendering and screencopy validation from protocol-reported dimensions.	Store layer-surface configure width and height and use them for the source SHM buffer and damage. Compute the 64×64 capture region from the configured layer dimensions. Continue validating full-output and damaged-region captures against the rendered red frame.	tests/protocols/wlr-screencopy-unstable-v1/wlr-screencopy-unstable-v1.c tests/protocols/wlr-screencopy-unstable-v1/screencopy-test.h
Improve screencopy test diagnostics and maintainability.	Capture render-state transitions and output commit status around server-side rendering. Report frame event metadata, pixel mismatches, and render state on failures. Reformat and reorganize the C client and document the explicit fixture and configure-derived sizing.	tests/protocols/wlr-screencopy-unstable-v1/wlr-screencopy-unstable-v1.c tests/protocols/wlr-screencopy-unstable-v1/setup.cpp tests/protocols/wlr-screencopy-unstable-v1/screencopy-test.h tests/protocols/wlr-screencopy-unstable-v1/README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-bot]

TAG Bot

New tag: 0.10.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1392

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook