Skip to content

fix(layer-shell): resolve output layer container by WOutput - #1402

Draft
zzxyb wants to merge 1 commit into
linuxdeepin:masterfrom
zzxyb:layer-shell
Draft

zzxyb wants to merge 1 commit into
linuxdeepin:masterfrom
zzxyb:layer-shell

Conversation

@zzxyb

@zzxyb zzxyb commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Use the underlying WOutput when resolving an output layer surface container from an Output wrapper. Keep both lookup overloads on the same identity so containers can be found reliably.

Log: fix output layer surface container lookup
Influence: layer-shell output surface management

Summary by Sourcery

Bug Fixes:

  • Fix output layer surface container lookup by resolving wrapped outputs through their underlying WOutput identity.

Use the underlying WOutput when resolving an output layer surface container
from an Output wrapper. Keep both lookup overloads on the same identity so
containers can be found reliably.

Log: fix output layer surface container lookup
Influence: layer-shell output surface management
@zzxyb
zzxyb requested a review from zccrs September 14, 2026 08:22
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zzxyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Layer-shell output surface container resolution now unwraps Output objects and uses the underlying WOutput for lookup, keeping both overloads consistent and ensuring containers are found by the identity they store.

Sequence diagram for layer-shell output container lookup

sequenceDiagram
    participant Caller
    participant LayerSurfaceContainer
    participant Output
    participant WOutput
    participant OutputLayerSurfaceContainer

    Caller->>LayerSurfaceContainer: getSurfaceContainer(output)
    LayerSurfaceContainer->>Output: output()
    Output-->>LayerSurfaceContainer: WOutput
    LayerSurfaceContainer->>LayerSurfaceContainer: getSurfaceContainer(WOutput)
    LayerSurfaceContainer->>OutputLayerSurfaceContainer: output()
    OutputLayerSurfaceContainer-->>LayerSurfaceContainer: matching WOutput
    LayerSurfaceContainer-->>Caller: OutputLayerSurfaceContainer
Loading

File-Level Changes

Change Details Files
Unifies output-layer container lookup around the underlying WOutput identity.
  • Delegates Output-wrapper lookup to the existing WOutput overload.
  • Removes the separate container iteration and wrapper-pointer comparison path.
  • Preserves a single identity-based lookup path for reliable container resolution.
src/core/layersurfacecontainer.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@zzxyb
zzxyb marked this pull request as draft September 14, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants