Conversation
Use the underlying WOutput when resolving an output layer surface container from an Output wrapper. Keep both lookup overloads on the same identity so containers can be found reliably. Log: fix output layer surface container lookup Influence: layer-shell output surface management
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zzxyb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideLayer-shell output surface container resolution now unwraps Output objects and uses the underlying WOutput for lookup, keeping both overloads consistent and ensuring containers are found by the identity they store. Sequence diagram for layer-shell output container lookupsequenceDiagram
participant Caller
participant LayerSurfaceContainer
participant Output
participant WOutput
participant OutputLayerSurfaceContainer
Caller->>LayerSurfaceContainer: getSurfaceContainer(output)
LayerSurfaceContainer->>Output: output()
Output-->>LayerSurfaceContainer: WOutput
LayerSurfaceContainer->>LayerSurfaceContainer: getSurfaceContainer(WOutput)
LayerSurfaceContainer->>OutputLayerSurfaceContainer: output()
OutputLayerSurfaceContainer-->>LayerSurfaceContainer: matching WOutput
LayerSurfaceContainer-->>Caller: OutputLayerSurfaceContainer
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
zzxyb
marked this pull request as draft
September 14, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the underlying WOutput when resolving an output layer surface container from an Output wrapper. Keep both lookup overloads on the same identity so containers can be found reliably.
Log: fix output layer surface container lookup
Influence: layer-shell output surface management
Summary by Sourcery
Bug Fixes: