fix(lockscreen): keep global login view above per-output greeter - #1408
Merged
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFix lock-screen stacking during output hot-plugging by explicitly placing the global login view above per-output greeter backgrounds and repositioning it whenever a new output is added. Sequence diagram for lock-screen output hot-plug stackingsequenceDiagram
participant OutputManager
participant LockScreen
participant LoginView
participant GreeterBackground
OutputManager->>LockScreen: addOutput(output)
LockScreen->>GreeterBackground: create per-output background
LockScreen->>LockScreen: repositionLoginView()
LockScreen->>LoginView: setZ(1)
LoginView-->>GreeterBackground: remains above background
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Raise the global login view's stacking order so greeter backgrounds created by hot-added outputs cannot occlude it. 提高全局登录界面层级,避免热插拔输出新增的每屏背景遮挡登录界面。 Log: 修复热插拔输出后锁屏登录界面被遮挡 PMS: BUG-377311 Influence: 多屏环境下热插拔输出时锁屏登录界面仍显示在鼠标所在屏。
glyvut
marked this pull request as ready for review
September 15, 2026 13:33
zccrs
approved these changes
Sep 16, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: glyvut, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the global login view's stacking order so greeter backgrounds created by hot-added outputs cannot occlude it.
提高全局登录界面层级,避免热插拔输出新增的每屏背景遮挡登录界面。
Log: 修复热插拔输出后锁屏登录界面被遮挡
Influence: 多屏环境下热插拔输出时锁屏登录界面仍显示在鼠标所在屏。
Summary by Sourcery
Bug Fixes: