Skip to content

fix(lockscreen): keep global login view above per-output greeter - #1408

Merged
zccrs merged 1 commit into
linuxdeepin:masterfrom
glyvut:greet
Sep 16, 2026
Merged

zccrs merged 1 commit into
linuxdeepin:masterfrom
glyvut:greet

Conversation

@glyvut

@glyvut glyvut commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Raise the global login view's stacking order so greeter backgrounds created by hot-added outputs cannot occlude it.

提高全局登录界面层级,避免热插拔输出新增的每屏背景遮挡登录界面。

Log: 修复热插拔输出后锁屏登录界面被遮挡
Influence: 多屏环境下热插拔输出时锁屏登录界面仍显示在鼠标所在屏。

Summary by Sourcery

Bug Fixes:

  • Keep the global lock-screen login view visible above greeter backgrounds when outputs are hot-plugged.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fix lock-screen stacking during output hot-plugging by explicitly placing the global login view above per-output greeter backgrounds and repositioning it whenever a new output is added.

Sequence diagram for lock-screen output hot-plug stacking

sequenceDiagram
    participant OutputManager
    participant LockScreen
    participant LoginView
    participant GreeterBackground

    OutputManager->>LockScreen: addOutput(output)
    LockScreen->>GreeterBackground: create per-output background
    LockScreen->>LockScreen: repositionLoginView()
    LockScreen->>LoginView: setZ(1)
    LoginView-->>GreeterBackground: remains above background
Loading

File-Level Changes

Change Details Files
Ensure the global login view is restored above newly added per-output greeter backgrounds.
  • Reposition the login view after adding a hot-plugged output and its background item.
  • Assign the login view a positive Z value so it renders above per-output greeter content.
  • Retain the existing repositioning logic during login-view creation.
src/core/lockscreen.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Raise the global login view's stacking order so greeter backgrounds
created by hot-added outputs cannot occlude it.

提高全局登录界面层级,避免热插拔输出新增的每屏背景遮挡登录界面。

Log: 修复热插拔输出后锁屏登录界面被遮挡
PMS: BUG-377311
Influence: 多屏环境下热插拔输出时锁屏登录界面仍显示在鼠标所在屏。
@glyvut
glyvut marked this pull request as ready for review September 15, 2026 13:33

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glyvut, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs
zccrs merged commit 2a20f07 into linuxdeepin:master Sep 16, 2026
7 checks passed
@glyvut
glyvut deleted the greet branch September 16, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants