Skip to content

fix(smoke): copy packed tarball instead of renaming it - #2172

Merged
lukasIO merged 2 commits into
mainfrom
claude/smoke-test-main-failure-0fb8a8
Oct 21, 2026
Merged

lukasIO merged 2 commits into
mainfrom
claude/smoke-test-main-failure-0fb8a8

Conversation

@lukasIO

@lukasIO lukasIO commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

The Smoke workflow fails on main before any test runs (run). prepare-package.mjs packs the SDK into a temp folder, then moves the tarball into smoke-tests/ with renameSync. The Ubuntu 26.04 runner mounts /tmp as tmpfs, a separate filesystem. A rename cannot cross filesystems, so the step exits with EXDEV: cross-device link not permitted.

This change copies the tarball with copyFileSync. The copy overwrites an old tarball, so the explicit delete goes away. The finally block still removes the temp folder.

No package code changes, so there is no changeset.

🤖 Generated with Claude Code

On Ubuntu 26.04 runners /tmp is a tmpfs, so renameSync from the
staging dir into the workspace fails with EXDEV.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fb41126

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lukasIO
lukasIO requested a review from davidliu October 21, 2026 09:15
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 115.86 KB (0%)
dist/livekit-client.umd.js 125.1 KB (0%)
dist/core/core.mjs 78.55 KB (0%)

@lukasIO
lukasIO merged commit acd1352 into main Oct 21, 2026
7 checks passed
@lukasIO
lukasIO deleted the claude/smoke-test-main-failure-0fb8a8 branch October 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants