Repository navigation
fix(smoke): copy packed tarball instead of renaming it - #2172
Merged
Merged
Conversation
On Ubuntu 26.04 runners /tmp is a tmpfs, so renameSync from the staging dir into the workspace fails with EXDEV. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
davidliu
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Smoke workflow fails on main before any test runs (run).
prepare-package.mjspacks the SDK into a temp folder, then moves the tarball intosmoke-tests/withrenameSync. The Ubuntu 26.04 runner mounts/tmpas tmpfs, a separate filesystem. A rename cannot cross filesystems, so the step exits withEXDEV: cross-device link not permitted.This change copies the tarball with
copyFileSync. The copy overwrites an old tarball, so the explicit delete goes away. Thefinallyblock still removes the temp folder.No package code changes, so there is no changeset.
🤖 Generated with Claude Code