Skip to content

Signalling WebSocket over Network.framework: URLSession keeps every WebSocket session after close #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimofeyIvanenko wants to merge 13 commits into from
Closed

Signalling WebSocket over Network.framework: URLSession keeps every WebSocket session after close #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4d13f8
Signalling WebSocket over Network.framework: URLSession keeps every W…
TimofeyIvanenko Oct 26, 2026
1f1bc06
WebSocket upgrade probe sends the escaped request target; Network.fra…
TimofeyIvanenko Oct 26, 2026
209b961
WebSocket: wait on an AsyncCompleter instead of a private Once contin…
pblazej Oct 26, 2026
c484db1
WebSocket: a peer FIN without a close frame fails the receive
pblazej Oct 26, 2026
743b0f2
Delete the unused WebSocket.makeRequest and its test
pblazej Oct 26, 2026
6a89df5
Drop the redundant maximumMessageSize assignment
pblazej Oct 26, 2026
632e35e
Decode text frames with the failable String(bytes:encoding:)
pblazej Oct 26, 2026
de4fe37
Add WebSocket lifecycle tests against a misbehaving server
pblazej Oct 26, 2026
2c04909
WebSocket lifecycle tests: unconditional server teardown, no private …
pblazej Oct 26, 2026
c449a5b
WebSocket lifecycle tests: the fake server reads whole client frames
pblazej Oct 26, 2026
3e9b6cb
Changeset: the signalling connection no longer goes through a system …
TimofeyIvanenko Oct 26, 2026
2d62b2d
Match the URLSession signalling socket on Network.framework
pblazej Oct 29, 2026
672d997
Cancel each WebSocket connection once after closing
pblazej Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changes/websocket-network-framework
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
patch type="fixed" "Stop leaking about 25 KB per signalling connection: the WebSocket runs over Network.framework, as Foundation keeps every URLSession that ran a WebSocket task alive after it is closed; a rejected upgrade still reports its HTTP status"
patch type="changed" "The signalling WebSocket fails on an HTTP redirect and does not answer HTTP authentication challenges. livekit-server sends neither on the signal upgrade"
Loading
Loading