Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/pion-ice-ping-prefix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

Ignore pion/ice "Failed to ping without candidate pairs" warning
1 change: 1 addition & 0 deletions logger/pionlogger/logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var (
pionIgnoredPrefixes = map[string]*prefixSet{
"ice": {
"pingAllCandidates called with no candidate pairs",
"Failed to ping without candidate pairs",
"failed to send packet: io: read/write on closed pipe",
"Ignoring remote candidate with tcpType active",
"discard message from",
Expand Down
7 changes: 7 additions & 0 deletions logger/pionlogger/logger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,10 @@ func TestPrefixFilter(t *testing.T) {
require.True(t, f["tcp_mux"].Match("error closing connection"))
require.True(t, f["tcp_mux"].Match("test"))
}

func TestIgnoredPrefixes(t *testing.T) {
f := NewPrefixFilter(nil)

require.True(t, f["ice"].Match("Failed to ping without candidate pairs. Connection is not possible yet."))
require.False(t, f["ice"].Match("Failed to handle message"))
}
Loading