Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/protocol-semconv.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
livekit-protocol: patch
---

Add `semconv`, the telemetry names and enum values generated from the protocol's Weaver registry, and move the protocol submodule to `003613b7`.
5 changes: 5 additions & 0 deletions .changeset/telemetry-semconv.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
livekit-telemetry: minor
---

Take every telemetry name from the protocol registry (`livekit_protocol::semconv`) and send its spelling: `lk.room_sid`, `lk.participant_id`, `lk.track_sid`, `lk.pii.room_name`, `lk.pii.participant_identity`, `lk.pii.remote_participant_identity`, `lk.track_source` with the RTC FFI `TrackSource` names, and `lk.disconnect_reason` with the protobuf `DisconnectReason` names.
1 change: 1 addition & 0 deletions .github/workflows/license-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@ jobs:
-ignore "livekit-protocol/src/livekit.agent.serde.rs" \
-ignore "livekit-protocol/src/logger.rs" \
-ignore "livekit-protocol/src/logger.serde.rs" \
-ignore "livekit-protocol/src/semconv.rs" \
-ignore "livekit-api/src/public_api/generated.rs" \
**/*.{rs,cpp,c}
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions livekit-protocol/generate_proto.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@


PROTOCOL=${PROTOCOL:-protocol/protobufs}
SEMCONV=${SEMCONV:-protocol/otel/gen/rust/semconv.rs}
OUT_RUST=src

# The telemetry names: generated in the protocol repository by Weaver (`otel/generate.sh`).
cp "$SEMCONV" $OUT_RUST/semconv.rs

protoc \
-I=$PROTOCOL \
--prost_out=$OUT_RUST \
Expand Down
2 changes: 1 addition & 1 deletion livekit-protocol/protocol
Submodule protocol updated 117 files
4 changes: 4 additions & 0 deletions livekit-protocol/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,7 @@ pub mod agent {
pub mod logger {
include!("logger.rs");
}

// Generated by `generate_proto.sh` from `protocol/otel/gen/rust/semconv.rs`.
#[rustfmt::skip]
pub mod semconv;
Loading
Loading