Repository navigation
Parse fmtp lines once per codec search - #6
Merged
Merged
Conversation
getCodecs and SetCodecPreferences searched codecs in a loop, and each search parsed the fmtp lines of all media engine codecs again. Parse them once per call. Use string matches instead of maps for defaultClockRate and defaultChannels. Backport of pion#3615. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Merging this @cnderrauber and will tag it and pick it up. Have also filed a PR upstream for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of pion/webrtc#3615.
getCodecsandSetCodecPreferencessearched codecs in a loop. Each search parsed the fmtp lines of all media engine codecs again. Now each call parses them once.defaultClockRateanddefaultChannelsalso use string matches instead of a map.Benchmark with the 24 default video codecs (12 primary + 12 RTX), on this branch:
getCodecsdrops from about 60 µs, 152 KB and 1692 allocs to about 17 µs, 39 KB and 391 allocs.🤖 Generated with Claude Code